Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5695)

Unified Diff: chrome/browser/hang_monitor/hung_plugin_action.h

Issue 9958104: Log when a browser plugin hangs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update based on jam@'s review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/hang_monitor/hung_plugin_action.h
diff --git a/chrome/browser/hang_monitor/hung_plugin_action.h b/chrome/browser/hang_monitor/hung_plugin_action.h
index 4958defbfac39a9800f492ef5a99c7ae371f33cf..70e03ae7139b5ee38ae7183f86e53a7d4dd5478b 100644
--- a/chrome/browser/hang_monitor/hung_plugin_action.h
+++ b/chrome/browser/hang_monitor/hung_plugin_action.h
@@ -36,9 +36,10 @@ class HungPluginAction : public HungWindowDetector::HungWindowNotification {
static BOOL CALLBACK DismissMessageBox(HWND window, LPARAM ignore);
protected:
- bool GetPluginName(HWND plugin_window,
- DWORD browser_process_id,
- std::wstring *plugin_name);
+ bool GetPluginNameAndVersion(HWND plugin_window,
+ DWORD browser_process_id,
+ std::wstring *plugin_name,
+ std::wstring *plugin_version);
// The currently hung plugin window that we are prompting the user about
HWND current_hung_plugin_window_;
};
« no previous file with comments | « no previous file | chrome/browser/hang_monitor/hung_plugin_action.cc » ('j') | chrome/browser/hang_monitor/hung_plugin_action.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698