[WebUI] Fix rest of CSS style nits in misc. dirs so I can turn on CSS checker.

[WebUI] Fix rest of CSS style nits in misc. dirs so I can turn on CSS checker.

R=estade@chromium.org
BUG=120369
TEST=Stuff still works, chrome/browser/resources/PRESUBMIT.py is happy.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130559

[Evan Stade, 2012-04-03 02:59:48]

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:78: content: ' ';
why is this ' ' while the other one is ''

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:201: /* min-width and
max-width are used by the split pane. */
comment is in the wrong place now

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:266: background-color:
hsla(214, 91%, 85%, .5);
I don't recall any style dictate that provides for the use of hsl/hsla

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css
(right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css:4: */
poop

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css:6: * {
this selector should be banned imo

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/cloud_print/cloud_print_setup_done.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_done.css:4: */
poop

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_done.css:8: background:
#fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/cloud_print/cloud_print_setup_login.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_login.css:4: */
poop

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_login.css:8: background:
#fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/downloads/downloads.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/downloads/downloads.css:82: no-repeat 100% 100%;
right bottom

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/downloads/downloads.css:88: background-position: 0
100%;
left bottom

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/extensions_infobar_mac.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/extensions_infobar_mac.css:10: background:
-webkit-linear-gradient(#EBEBEB, #CFCFCF);
seems like we normally use lower case hex values?

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/extensions_infobar_mac.css:13: height: 36px; /*
Infobars are limited to 36-72px */
two spaces before /*

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/feedback.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/feedback.css:4: */
boop

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/flags.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/flags.css:4: */
.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/keyboard/layout_fr.js (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/keyboard/layout_fr.js:69: new ShiftKey('left-shift'),
what is this? this file is generated. did you change the generation script
somewhere?

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/keyboard/main.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/keyboard/main.css:4: */
:(

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/plugins.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/plugins.css:4: */
:.(

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/plugins.js (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/plugins.js:199: var tmiModeExpanded = false;
this is awesome if tmi == too much info

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/plugins.js:213: tmiModeExpanded ? 'show-tmi-mode' :
'hide-tmi-mode';
my hawk vision tells me this fits on one line

really I think that in JS we should just be toggling a class somewhere and leave
the rest to CSS but please refrain from making a functional change like that in
this CL.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/quota_internals/main.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/quota_internals/main.css:4: */
nooo

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/shared/css/chrome_shared.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/shared/css/chrome_shared.css:87: .navbar-item:focus {
, .navbar-item-selected

imo

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:155: background: #fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:310: color: #fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:322: margin: 0 0 1.2em 0.4em;
use -webkit-margin-start and -webkit-margin-end instead?

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:328: background-image:
-webkit-linear-gradient(top, rgb(77, 144, 254),
why is this necessary to repeat?

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:330: border: 1px solid rgb(47,
91, 183);
you need only change border-color

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:336: border: 1px solid rgb(77,
144, 254);
ditto

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:347: -webkit-box-shadow: inset 0
0 0 1px #fff, 0 1px 1px rgba(0, 0, 0, 0.1);
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:356: color: #fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:366: background-color: #fff;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:470: color: #fff !important;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:480: color: #fff !important;
white

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:484: color: #fff !important;
white

[Evan Stade, 2012-04-03 03:08:02]

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:307: background:
-webkit-canvas(drop-down-arrow) 100% 50% no-repeat;
left middle

[Dan Beam, 2012-04-03 03:15:09]

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:79: white-space: pre;
estade and I think ^ this will likely make a difference in this regard

[Dan Beam, 2012-04-03 04:15:06]

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:201: /* min-width and
max-width are used by the split pane. */
On 2012/04/03 02:59:48, Evan Stade wrote:
> comment is in the wrong place now

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:266: background-color:
hsla(214, 91%, 85%, .5);
On 2012/04/03 02:59:48, Evan Stade wrote:
> I don't recall any style dictate that provides for the use of hsl/hsla

The style guide says:

  Prefer rgb() or rgba() with decimal values instead of hex notation (#rrggbb).

It doesn't say "Don't use hsl/hsla()"

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:307: background:
-webkit-canvas(drop-down-arrow) 100% 50% no-repeat;
On 2012/04/03 03:08:02, Evan Stade wrote:
> left middle

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css
(right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> poop

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bookmark_all_tabs.css:6: * {
On 2012/04/03 02:59:48, Evan Stade wrote:
> this selector should be banned imo

put it in the style guide

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/cloud_print/cloud_print_setup_done.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_done.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> poop

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_done.css:8: background:
#fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/cloud_print/cloud_print_setup_login.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_login.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> poop

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/cloud_print/cloud_print_setup_login.css:8: background:
#fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/downloads/downloads.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/downloads/downloads.css:4: */
Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/downloads/downloads.css:82: no-repeat 100% 100%;
On 2012/04/03 02:59:48, Evan Stade wrote:
> right bottom

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/downloads/downloads.css:88: background-position: 0
100%;
On 2012/04/03 02:59:48, Evan Stade wrote:
> left bottom

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/extensions_infobar_mac.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/extensions_infobar_mac.css:10: background:
-webkit-linear-gradient(#EBEBEB, #CFCFCF);
On 2012/04/03 02:59:48, Evan Stade wrote:
> seems like we normally use lower case hex values?

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/extensions_infobar_mac.css:13: height: 36px; /*
Infobars are limited to 36-72px */
On 2012/04/03 02:59:48, Evan Stade wrote:
> two spaces before /*

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/feedback.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/feedback.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> boop

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/flags.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/flags.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> .

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/history/history.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/history/history.css:4: */
Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/keyboard/layout_fr.js (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/keyboard/layout_fr.js:69: new ShiftKey('left-shift'),
On 2012/04/03 02:59:48, Evan Stade wrote:
> what is this? this file is generated. did you change the generation script
> somewhere?

like we talked about, I'll just revert this as I can't find
gen_keyboard_layouts.py anywhere in the source tree...

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/keyboard/main.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/keyboard/main.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> :(

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/plugins.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/plugins.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> :.(

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/plugins.js (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/plugins.js:213: tmiModeExpanded ? 'show-tmi-mode' :
'hide-tmi-mode';
On 2012/04/03 02:59:48, Evan Stade wrote:
> my hawk vision tells me this fits on one line
> 
> really I think that in JS we should just be toggling a class somewhere and
leave
> the rest to CSS but please refrain from making a functional change like that
in
> this CL.

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/quota_internals/main.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/quota_internals/main.css:4: */
On 2012/04/03 02:59:48, Evan Stade wrote:
> nooo

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/shared/css/chrome_shared.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/shared/css/chrome_shared.css:87: .navbar-item:focus {
On 2012/04/03 02:59:48, Evan Stade wrote:
> , .navbar-item-selected
> 
> imo

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:155: background: #fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:310: color: #fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:322: margin: 0 0 1.2em 0.4em;
On 2012/04/03 02:59:48, Evan Stade wrote:
> use -webkit-margin-start and -webkit-margin-end instead?

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:328: background-image:
-webkit-linear-gradient(top, rgb(77, 144, 254),
On 2012/04/03 02:59:48, Evan Stade wrote:
> why is this necessary to repeat?

don't know

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:330: border: 1px solid rgb(47,
91, 183);
On 2012/04/03 02:59:48, Evan Stade wrote:
> you need only change border-color

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:336: border: 1px solid rgb(77,
144, 254);
On 2012/04/03 02:59:48, Evan Stade wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:347: -webkit-box-shadow: inset 0
0 0 1px #fff, 0 1px 1px rgba(0, 0, 0, 0.1);
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:356: color: #fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:366: background-color: #fff;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:470: color: #fff !important;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:480: color: #fff !important;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:484: color: #fff !important;
On 2012/04/03 02:59:48, Evan Stade wrote:
> white

Done.

[Tyler Breisacher (Chromium), 2012-04-03 18:09:36]

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:23: color: hsl(0, 0%,
70%);
Generally, we prefer "0" to "0%" but I guess for hsl, we make an exception?

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/gallery.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/file_manager/css/gallery.css:729: opacity: 0;
Doesn't this change the behavior? The rule

.gallery .prompt[state='fadein'] {
  opacity: 1
}

seems to be gone now.

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/file_manager/css/gallery.css:783: opacity: 0.0;
If we're going to get rid of "0px" and "0%" and "0em" and so on, should we also
get rid of 0.0? Don't change it now since it's not in the style guide, but we
could consider adding that.

[Dan Beam, 2012-04-03 19:42:01]

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:23: color: hsl(0, 0%,
70%);
On 2012/04/03 18:09:36, Tyler Breisacher wrote:
> Generally, we prefer "0" to "0%" but I guess for hsl, we make an exception?

There already is one:

  Exception: 0% values in lists of percentages like hsl(5, 0%, 90%) or within
@keyframe directives, e.g.:

http://dev.chromium.org/developers/web-development-style-guide#TOC-CSS

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/gallery.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/file_manager/css/gallery.css:729: opacity: 0;
On 2012/04/03 18:09:36, Tyler Breisacher wrote:
> Doesn't this change the behavior? The rule
> 
> .gallery .prompt[state='fadein'] {
>   opacity: 1
> }
> 
> seems to be gone now.

yes, good catch, I'll just undo as having a second rule is more chars than just
have 2 separate rules

https://chromiumcodereview.appspot.com/9958101/diff/8001/chrome/browser/resou...
chrome/browser/resources/file_manager/css/gallery.css:783: opacity: 0.0;
On 2012/04/03 18:09:36, Tyler Breisacher wrote:
> If we're going to get rid of "0px" and "0%" and "0em" and so on, should we
also
> get rid of 0.0? Don't change it now since it's not in the style guide, but we
> could consider adding that.

This was a bug in the checker - fixed and tests added.

[Tyler Breisacher (Chromium), 2012-04-03 19:44:37]

On 2012/04/03 19:42:01, Dan Beam wrote:
> This was a bug in the checker - fixed and tests added.

Woohoo. TDD FTW. lgtm.

[Evan Stade, 2012-04-03 23:57:27]

lgtm if you fix the borders

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:266: background-color:
hsla(214, 91%, 85%, .5);
On 2012/04/03 04:15:06, Dan Beam wrote:
> On 2012/04/03 02:59:48, Evan Stade wrote:
> > I don't recall any style dictate that provides for the use of hsl/hsla
> 
> The style guide says:
> 
>   Prefer rgb() or rgba() with decimal values instead of hex notation
(#rrggbb).
> 
> It doesn't say "Don't use hsl/hsla()"

right, because I don't think we considered the use of hsl/hsla. I think the
reasoning that lead us to conclude rgb over hex (viz., standardizing on a single
system to make manual value comparisons easier) would also logically imply hsl
should be avoided.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:328: background-image:
-webkit-linear-gradient(top, rgb(77, 144, 254),
On 2012/04/03 04:15:06, Dan Beam wrote:
> On 2012/04/03 02:59:48, Evan Stade wrote:
> > why is this necessary to repeat?
> 
> don't know

oh, it's not repeating. The second value is different.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:389: border: 1px solid #b9b9b9;
only change border-color

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:396: border: 1px solid rgb(77,
144, 254);
only change border-color

[Dan Beam, 2012-04-04 00:54:49]

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:266: background-color:
hsla(214, 91%, 85%, .5);
On 2012/04/03 23:57:27, Evan Stade wrote:
> On 2012/04/03 04:15:06, Dan Beam wrote:
> > On 2012/04/03 02:59:48, Evan Stade wrote:
> > > I don't recall any style dictate that provides for the use of hsl/hsla
> > 
> > The style guide says:
> > 
> >   Prefer rgb() or rgba() with decimal values instead of hex notation
> (#rrggbb).
> > 
> > It doesn't say "Don't use hsl/hsla()"
> 
> right, because I don't think we considered the use of hsl/hsla. I think the
> reasoning that lead us to conclude rgb over hex (viz., standardizing on a
single
> system to make manual value comparisons easier) would also logically imply hsl
> should be avoided.

we considered the use of hsl/hsla() when ignoring 0%'s elsewhere in the style
guide (http://dev.chromium.org/developers/web-development-style-guide#TOC-CSS),
but if you want there to be One True Way™ we need to work to standardize.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:389: border: 1px solid #b9b9b9;
On 2012/04/03 23:57:27, Evan Stade wrote:
> only change border-color

Done.

https://chromiumcodereview.appspot.com/9958101/diff/2001/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:396: border: 1px solid rgb(77,
144, 254);
On 2012/04/03 23:57:27, Evan Stade wrote:
> only change border-color

Done.

[commit-bot: I haz the power, 2012-04-04 01:04:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9958101/82

[commit-bot: I haz the power, 2012-04-04 01:04:25]

Can't apply patch for file chrome/browser/resources/extensions_infobar.css.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/extensions_infobar.css
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/extensions_infobar.css.rej

[commit-bot: I haz the power, 2012-04-04 01:07:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9958101/5143

[commit-bot: I haz the power, 2012-04-04 01:07:25]

Can't apply patch for file chrome/browser/resources/extensions_infobar.css.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/extensions_infobar.css
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/extensions_infobar.css.rej

[Dan Beam, 2012-04-04 01:08:27]

I'll land manually, as I've apparently baffled `patch`.

[commit-bot: I haz the power, 2012-04-04 05:59:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9958101/5143

[commit-bot: I haz the power, 2012-04-04 05:59:31]

Can't apply patch for file chrome/browser/resources/extensions_infobar.css.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/extensions_infobar.css
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/extensions_infobar.css.rej