Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: tests/standalone/src/io/HttpServerTest.dart

Issue 9958060: Make sure to don't close the HTTP Server until all the headers have been flushed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/io/HttpServerTest.dart
===================================================================
--- tests/standalone/src/io/HttpServerTest.dart (revision 6083)
+++ tests/standalone/src/io/HttpServerTest.dart (working copy)
@@ -20,10 +20,7 @@
server.onRequest = (HttpRequest request, HttpResponse response) {
request.inputStream.onClosed = () {
response.outputStream.close();
- server.close();
- Expect.throws(() => server.port);
serverPort.close();
- onDone();
};
};
@@ -44,10 +41,13 @@
response.inputStream.onClosed = () {
client.shutdown();
clientPort.close();
+ server.close();
+ Expect.throws(() => server.port);
+ onDone();
};
};
conn.onError = (Exception e) {
- Expect.fail("Unexpected error in Http Client");
+ Expect.fail("Unexpected error in Http Client: $e");
};
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698