Issue 9956157: views: Make everything in crypto module password dialog private except the ctor.

Issue 9956157: views: Make everything in crypto module password dialog private except the ctor. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Make everything in crypto module password dialog private except the ctor. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132516

Patch Set 2 : peter view #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -96 lines)			Patch
M	chrome/browser/ui/views/crypto_module_password_dialog_view.h	View		2 chunks	+17 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/views/crypto_module_password_dialog_view.cc	View	1	4 chunks	+57 lines, -58 lines	0 comments	Download
M	chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc	View	1	1 chunk	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/9956157/diff/1/chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc File chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc (right): http://codereview.chromium.org/9956157/diff/1/chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc#newcode15 chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc:15: const char kSlotName[] = "slot"; Nit: These can ...

8 years, 8 months ago (2012-04-16 22:31:13 UTC) #2

tfarina

On 2012/04/16 22:31:13, Peter Kasting wrote: > LGTM > > http://codereview.chromium.org/9956157/diff/1/chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc > File chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc > ...

8 years, 8 months ago (2012-04-16 22:34:03 UTC) #3

Peter Kasting

8 years, 8 months ago (2012-04-16 22:35:45 UTC) #4

On 2012/04/16 22:34:03, tfarina wrote:
> On 2012/04/16 22:31:13, Peter Kasting wrote:
>
http://codereview.chromium.org/9956157/diff/1/chrome/browser/ui/views/crypto_...
> > chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc:15:
> const
> > char kSlotName[] = "slot";
> > Nit: These can just go in CreateCryptoDialog()
> 
> As const char* kSlotName = "slot"; or just fold the constant directly?

I don't really care

Expand Messages | Collapse Messages