Issue 9956154: TabContents -> WebContentsImpl, part 16

Issue 9956154: TabContents -> WebContentsImpl, part 16 (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TabContents -> WebContentsImpl, part 16 Remove "tab contents". BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132571

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -40 lines)			Patch
M	content/browser/accessibility/browser_accessibility_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_web_contents_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_delegate_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_gtk.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_drag_dest_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_drag_source_gtk.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/web_contents/web_drag_source_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/accessibility_messages.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/web_contents.h	View		7 chunks	+13 lines, -12 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/public/browser/web_contents_view.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/shell_messages.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/test_renderer_host.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9956154/1

8 years, 8 months ago (2012-04-17 13:18:37 UTC) #3

commit-bot: I haz the power

Can't apply patch for file content/browser/in_process_webkit/session_storage_namespace_impl.h. While running patch -p1 --forward --force; patching file content/browser/in_process_webkit/session_storage_namespace_impl.h ...

8 years, 8 months ago (2012-04-17 13:18:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9956154/3001

8 years, 8 months ago (2012-04-17 13:23:00 UTC) #5

commit-bot: I haz the power

8 years, 8 months ago (2012-04-17 13:40:33 UTC) #6

Try job failure for 9956154-3001 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Expand Messages | Collapse Messages