Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 9956149: Revert r132446 "Check the existence and executability of scm commands" (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Revert r132446 "Check the existence and executability of scm commands" This completely broke syncing on Windows. TBR=mukai@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -44 lines) Patch
M gclient_scm.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gclient_utils.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/gclient_scm_test.py View 26 chunks +0 lines, -28 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-16 19:51:14 UTC) #1
M-A Ruel
This caused "Error: svn command not found" or the same for git. On windows, you ...
8 years, 8 months ago (2012-04-16 19:57:45 UTC) #2
Jun Mukai
8 years, 8 months ago (2012-04-17 00:24:56 UTC) #3
lgtm

thanks for reverting... :(

Powered by Google App Engine
This is Rietveld 408576698