Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9956148: Add file thread in MessageHostContext. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov
Modified:
8 years, 8 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add file thread in MessageHostContext. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132544

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -40 lines) Patch
M remoting/host/chromoting_host_context.h View 1 4 chunks +9 lines, -6 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M remoting/host/chromoting_host_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_environment.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 6 chunks +8 lines, -14 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
8 years, 8 months ago (2012-04-16 18:50:00 UTC) #1
Wez
lgtm http://codereview.chromium.org/9956148/diff/1/remoting/host/chromoting_host_context.h File remoting/host/chromoting_host_context.h (right): http://codereview.chromium.org/9956148/diff/1/remoting/host/chromoting_host_context.h#newcode38 remoting/host/chromoting_host_context.h:38: virtual base::MessageLoopProxy* ui_message_loop(); Why have you moved this? ...
8 years, 8 months ago (2012-04-17 01:14:59 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9956148/diff/1/remoting/host/chromoting_host_context.h File remoting/host/chromoting_host_context.h (right): http://codereview.chromium.org/9956148/diff/1/remoting/host/chromoting_host_context.h#newcode38 remoting/host/chromoting_host_context.h:38: virtual base::MessageLoopProxy* ui_message_loop(); On 2012/04/17 01:14:59, Wez wrote: > ...
8 years, 8 months ago (2012-04-17 01:28:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9956148/9
8 years, 8 months ago (2012-04-17 01:28:26 UTC) #4
commit-bot: I haz the power
Try job failure for 9956148-9 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-17 01:56:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9956148/2004
8 years, 8 months ago (2012-04-17 02:41:48 UTC) #6
commit-bot: I haz the power
Try job failure for 9956148-2004 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-17 03:03:55 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 03:47:24 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698