Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9956127: Fix "Compilion" typo. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 6127)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -278,7 +278,7 @@
for (String line in testCase.output.stdout) {
if (line.startsWith('VM exited with signal 1073741819')) {
if (!alreadyPrintedWarning) {
- print("WARNING: VM crashed on this test with signal 1073741819. " +
+ print("WARNING: VM crashed on this test with signal 1073741819. " +
"This is a fake pass!!");
alreadyPrintedWarning = true;
}
@@ -383,7 +383,7 @@
Expect.isNotNull(outcome);
if (outcome.contains('compile-time error') && errors.length > 0) {
return true;
- } else if (outcome.contains('static type warning')
+ } else if (outcome.contains('static type warning')
&& staticWarnings.length > 0) {
return true;
} else if (outcome.isEmpty()
@@ -528,8 +528,8 @@
for (var line in testCase.output.stderr) print(line);
for (var line in testCase.output.stdout) print(line);
}
- if (allowRetries && testCase.usesWebDriver
- && testCase.output.unexpectedOutput
+ if (allowRetries && testCase.usesWebDriver
+ && testCase.output.unexpectedOutput
&& testCase.dynamic.numRetries > 0) {
// Selenium tests can be flaky. Try rerunning.
testCase.output.requestRetry = true;
@@ -561,8 +561,8 @@
stderr.add('test.dart: Compilation failed$suffix, exit code $exitCode\n');
testComplete(exitCode);
} else {
- stderr.add('test.dart: Compilion finished $suffix\n');
- stdout.add('test.dart: Compilion finished $suffix\n');
+ stderr.add('test.dart: Compilation finished $suffix\n');
+ stdout.add('test.dart: Compilation finished $suffix\n');
if (currentStep == totalSteps - 1 && testCase.usesWebDriver &&
!testCase.configuration['noBatch']) {
// Note: processQueue will always be non-null for runtime == ie, ff,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698