Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: src/url_canon_unittest.cc

Issue 9956109: Fix URLCanonTest.CanonicalizeFileSystemURL (Closed) Base URL: http://google-url.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/url_canon_unittest.cc
===================================================================
--- src/url_canon_unittest.cc (revision 170)
+++ src/url_canon_unittest.cc (working copy)
@@ -1678,8 +1678,6 @@
}
}
-/*
-TODO(ericu) bug 121671 this test fails.
#ifdef FULL_FILESYSTEM_URL_SUPPORT
TEST(URLCanonTest, CanonicalizeFileSystemURL) {
struct URLCase {
@@ -1693,7 +1691,7 @@
{"filesystem:http://www.foo.com/persistent/bob?query#ref", "filesystem:http://www.foo.com/persistent/bob?query#ref", true},
{"filesystem:fIle://\\temporary/", "filesystem:file:///temporary/", true},
{"filesystem:fiLe:///temporary", "filesystem:file:///temporary/", true},
- {"filesystem:file://///temporary", "filesystem:file:///temporary/", true},
+ {"filesystem:file:///////temporary", "filesystem:file:////", false},
{"filesystem:File:///temporary/Bob?qUery#reF", "filesystem:file:///temporary/Bob?qUery#reF", true},
};
@@ -1720,7 +1718,6 @@
}
}
#endif
-*/
TEST(URLCanonTest, CanonicalizePathURL) {
// Path URLs should get canonicalized schemes but nothing else.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698