Issue 9956109: Fix URLCanonTest.CanonicalizeFileSystemURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9956109: Fix URLCanonTest.CanonicalizeFileSystemURL (Closed)

Created:
8 years, 8 months ago by ericu

Modified:
8 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

I fixed the expectation [the URL is invalid] and added a few slashes to make it more obvious how we canonicalize bad filesystem:file URLs that are missing the storage type specifier. BUG=121671

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/url_canon_unittest.cc	View		3 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ericu

8 years, 8 months ago (2012-04-03 20:45:43 UTC) #3

Thanks; I'll pull them later.

On Tue, Apr 3, 2012 at 1:43 PM,  <brettw@chromium.org> wrote:
> LGTM, checked in as r171, I did not pull deps.
>
> https://chromiumcodereview.appspot.com/9956109/

Expand Messages | Collapse Messages