Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4828)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 9956097: suppress user/password dialog when re-enabling sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve Nicolas's comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
index 520182a82e99a9382e6aa6eb5fbed30e536e15fe..123f681afeaf53e63093e130f6f44446920c0c8c 100644
--- a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
@@ -286,6 +286,7 @@ static void CheckShowSyncSetupArgs(const DictionaryValue* dictionary,
TEST_F(SyncSetupHandlerTest, Basic) {
}
+#if !defined(OS_CHROMEOS)
TEST_F(SyncSetupHandlerTest, DisplayBasicLogin) {
EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
.WillRepeatedly(Return(false));
@@ -399,6 +400,7 @@ TEST_F(SyncSetupHandlerTest, HandleCaptcha) {
dictionary, "", false, GoogleServiceAuthError::CAPTCHA_REQUIRED,
kTestUser, true, kTestCaptchaImageUrl);
}
+#endif // !OS_CHROMEOS
TEST_F(SyncSetupHandlerTest, HandleFatalError) {
EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
@@ -419,6 +421,8 @@ TEST_F(SyncSetupHandlerTest, HandleFatalError) {
dictionary, "", true, GoogleServiceAuthError::NONE, "", true, "");
}
+#if !defined(OS_CHROMEOS)
+// TODO(kochi): We need equivalent tests for ChromeOS.
TEST_F(SyncSetupHandlerTest, UnrecoverableErrorInitializingSync) {
EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
.WillRepeatedly(Return(false));
@@ -493,6 +497,7 @@ TEST_F(SyncSetupHandlerTest, GaiaErrorInitializingSync) {
dictionary, "", false, GoogleServiceAuthError::SERVICE_UNAVAILABLE,
kTestUser, true, "");
}
+#endif // !OS_CHROMEOS
TEST_F(SyncSetupHandlerTest, TestSyncEverything) {
std::string args =

Powered by Google App Engine
This is Rietveld 408576698