Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: chrome/browser/sync/sync_prefs.cc

Issue 9956097: suppress user/password dialog when re-enabling sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolve Drew's comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_prefs.h" 5 #include "chrome/browser/sync/sync_prefs.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_number_conversions.h" 8 #include "base/string_number_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 26 matching lines...) Expand all
37 DCHECK(non_thread_safe_.CalledOnValidThread()); 37 DCHECK(non_thread_safe_.CalledOnValidThread());
38 sync_pref_observers_.AddObserver(sync_pref_observer); 38 sync_pref_observers_.AddObserver(sync_pref_observer);
39 } 39 }
40 40
41 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) { 41 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) {
42 DCHECK(non_thread_safe_.CalledOnValidThread()); 42 DCHECK(non_thread_safe_.CalledOnValidThread());
43 sync_pref_observers_.RemoveObserver(sync_pref_observer); 43 sync_pref_observers_.RemoveObserver(sync_pref_observer);
44 } 44 }
45 45
46 void SyncPrefs::ClearPreferences() { 46 void SyncPrefs::ClearPreferences() {
47 LOG(WARNING) << "ClearPreferences()";
47 DCHECK(non_thread_safe_.CalledOnValidThread()); 48 DCHECK(non_thread_safe_.CalledOnValidThread());
48 CHECK(pref_service_); 49 CHECK(pref_service_);
49 pref_service_->ClearPref(prefs::kSyncLastSyncedTime); 50 pref_service_->ClearPref(prefs::kSyncLastSyncedTime);
50 pref_service_->ClearPref(prefs::kSyncHasSetupCompleted); 51 pref_service_->ClearPref(prefs::kSyncHasSetupCompleted);
51 pref_service_->ClearPref(prefs::kSyncEncryptionBootstrapToken); 52 pref_service_->ClearPref(prefs::kSyncEncryptionBootstrapToken);
52 53
53 // TODO(nick): The current behavior does not clear 54 // TODO(nick): The current behavior does not clear
54 // e.g. prefs::kSyncBookmarks. Is that really what we want? 55 // e.g. prefs::kSyncBookmarks. Is that really what we want?
55 56
56 pref_service_->ClearPref(prefs::kSyncMaxInvalidationVersions); 57 pref_service_->ClearPref(prefs::kSyncMaxInvalidationVersions);
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 167
167 std::string SyncPrefs::GetEncryptionBootstrapToken() const { 168 std::string SyncPrefs::GetEncryptionBootstrapToken() const {
168 DCHECK(non_thread_safe_.CalledOnValidThread()); 169 DCHECK(non_thread_safe_.CalledOnValidThread());
169 return 170 return
170 pref_service_ ? 171 pref_service_ ?
171 pref_service_->GetString(prefs::kSyncEncryptionBootstrapToken) : ""; 172 pref_service_->GetString(prefs::kSyncEncryptionBootstrapToken) : "";
172 } 173 }
173 174
174 void SyncPrefs::SetEncryptionBootstrapToken(const std::string& token) { 175 void SyncPrefs::SetEncryptionBootstrapToken(const std::string& token) {
175 DCHECK(non_thread_safe_.CalledOnValidThread()); 176 DCHECK(non_thread_safe_.CalledOnValidThread());
176 CHECK(pref_service_);
177 pref_service_->SetString(prefs::kSyncEncryptionBootstrapToken, token); 177 pref_service_->SetString(prefs::kSyncEncryptionBootstrapToken, token);
178 } 178 }
179 179
180 std::string SyncPrefs::GetSpareBootstrapToken() const {
181 DCHECK(non_thread_safe_.CalledOnValidThread());
182 return pref_service_ ?
183 pref_service_->GetString(prefs::kSyncSpareBootstrapToken) : "";
184 }
185
186 void SyncPrefs::SetSpareBootstrapToken(const std::string& token) {
187 DCHECK(non_thread_safe_.CalledOnValidThread());
188 pref_service_->SetString(prefs::kSyncSpareBootstrapToken, token);
189 }
190
180 sync_notifier::InvalidationVersionMap SyncPrefs::GetAllMaxVersions() const { 191 sync_notifier::InvalidationVersionMap SyncPrefs::GetAllMaxVersions() const {
181 DCHECK(non_thread_safe_.CalledOnValidThread()); 192 DCHECK(non_thread_safe_.CalledOnValidThread());
182 if (!pref_service_) { 193 if (!pref_service_) {
183 return sync_notifier::InvalidationVersionMap(); 194 return sync_notifier::InvalidationVersionMap();
184 } 195 }
185 // Complicated gross code to convert from a string -> string 196 // Complicated gross code to convert from a string -> string
186 // DictionaryValue to a ModelType -> int64 map. 197 // DictionaryValue to a ModelType -> int64 map.
187 const base::DictionaryValue* max_versions_dict = 198 const base::DictionaryValue* max_versions_dict =
188 pref_service_->GetDictionary(prefs::kSyncMaxInvalidationVersions); 199 pref_service_->GetDictionary(prefs::kSyncMaxInvalidationVersions);
189 CHECK(max_versions_dict); 200 CHECK(max_versions_dict);
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 } 402 }
392 RegisterDataTypePreferredPref(type, enable_by_default); 403 RegisterDataTypePreferredPref(type, enable_by_default);
393 } 404 }
394 405
395 pref_service_->RegisterBooleanPref(prefs::kSyncManaged, 406 pref_service_->RegisterBooleanPref(prefs::kSyncManaged,
396 false, 407 false,
397 PrefService::UNSYNCABLE_PREF); 408 PrefService::UNSYNCABLE_PREF);
398 pref_service_->RegisterStringPref(prefs::kSyncEncryptionBootstrapToken, 409 pref_service_->RegisterStringPref(prefs::kSyncEncryptionBootstrapToken,
399 "", 410 "",
400 PrefService::UNSYNCABLE_PREF); 411 PrefService::UNSYNCABLE_PREF);
412 pref_service_->RegisterStringPref(prefs::kSyncSpareBootstrapToken,
413 "",
414 PrefService::UNSYNCABLE_PREF);
401 415
402 // We will start prompting people about new data types after the launch of 416 // We will start prompting people about new data types after the launch of
403 // SESSIONS - all previously launched data types are treated as if they are 417 // SESSIONS - all previously launched data types are treated as if they are
404 // already acknowledged. 418 // already acknowledged.
405 syncable::ModelTypeSet model_set; 419 syncable::ModelTypeSet model_set;
406 model_set.Put(syncable::BOOKMARKS); 420 model_set.Put(syncable::BOOKMARKS);
407 model_set.Put(syncable::PREFERENCES); 421 model_set.Put(syncable::PREFERENCES);
408 model_set.Put(syncable::PASSWORDS); 422 model_set.Put(syncable::PASSWORDS);
409 model_set.Put(syncable::AUTOFILL_PROFILE); 423 model_set.Put(syncable::AUTOFILL_PROFILE);
410 model_set.Put(syncable::AUTOFILL); 424 model_set.Put(syncable::AUTOFILL);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 if (types.Has(i->first)) 486 if (types.Has(i->first))
473 types_with_groups.PutAll(i->second); 487 types_with_groups.PutAll(i->second);
474 else 488 else
475 types_with_groups.RemoveAll(i->second); 489 types_with_groups.RemoveAll(i->second);
476 } 490 }
477 types_with_groups.RetainAll(registered_types); 491 types_with_groups.RetainAll(registered_types);
478 return types_with_groups; 492 return types_with_groups;
479 } 493 }
480 494
481 } // namespace browser_sync 495 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698