suppress user/password dialog when re-enabling sync

chrome/browser/ui/webui/sync_setup_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_setup_handler.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
@@ skipping 268 matching lines @@
   CheckString(dictionary, "user", user, false);
   CheckString(dictionary, "captchaUrl", captcha_url, false);
   CheckInt(dictionary, "error", error);
   CheckBool(dictionary, "fatalError", fatal_error, true);
   CheckBool(dictionary, "editable_user", user_is_editable);
 }
 
 TEST_F(SyncSetupHandlerTest, Basic) {
 }
 
+#if !defined(OS_CHROMEOS)
 TEST_F(SyncSetupHandlerTest, DisplayBasicLogin) {
   EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
       .WillRepeatedly(Return(false));
   handler_->OpenSyncSetup(false);
   EXPECT_EQ(&web_ui_,
             LoginUIServiceFactory::GetForProfile(
                 profile_.get())->current_login_ui());
   ASSERT_EQ(1U, web_ui_.call_data().size());
@@ skipping 93 matching lines @@
   std::string page;
   ASSERT_TRUE(data.arg1->GetAsString(&page));
   EXPECT_EQ(page, "login");
   // Now make sure that the appropriate params are being passed.
   DictionaryValue* dictionary;
   ASSERT_TRUE(data.arg2->GetAsDictionary(&dictionary));
   CheckShowSyncSetupArgs(
       dictionary, "", false, GoogleServiceAuthError::CAPTCHA_REQUIRED,
       kTestUser, true, kTestCaptchaImageUrl);
 }
+#endif  // !OS_CHROMEOS
 
 TEST_F(SyncSetupHandlerTest, HandleFatalError) {
   EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
       .WillRepeatedly(Return(false));
   handler_->ShowFatalError();
   ASSERT_EQ(1U, web_ui_.call_data().size());
   const TestWebUI::CallData& data = web_ui_.call_data()[0];
   EXPECT_EQ("SyncSetupOverlay.showSyncSetupPage", data.function_name);
   std::string page;
   ASSERT_TRUE(data.arg1->GetAsString(&page));
   EXPECT_EQ(page, "login");
   // Now make sure that the appropriate params are being passed.
   DictionaryValue* dictionary;
   ASSERT_TRUE(data.arg2->GetAsDictionary(&dictionary));
   CheckShowSyncSetupArgs(
       dictionary, "", true, GoogleServiceAuthError::NONE, "", true, "");
 }
 
+#if !defined(OS_CHROMEOS)

[Andrew T Wilson (Slow), 2012/04/03 17:45:13]

I think we'll still need some flavor of this test, since even on cros you can
get an unrecoverable error while starting up sync.

[kochi, 2012/04/03 21:55:29]

Added TODO.

On 2012/04/03 17:45:13, Andrew T Wilson wrote:

 TEST_F(SyncSetupHandlerTest, UnrecoverableErrorInitializingSync) {
   EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
       .WillRepeatedly(Return(false));
   // Open the web UI.
   handler_->OpenSyncSetup(false);
   ASSERT_EQ(1U, web_ui_.call_data().size());
   // Fake a successful GAIA request (gaia credentials valid, but signin not
   // complete yet).
@@ skipping 54 matching lines @@
   std::string page;
   ASSERT_TRUE(data.arg1->GetAsString(&page));
   EXPECT_EQ(page, "login");
   // Now make sure that the appropriate params are being passed.
   DictionaryValue* dictionary;
   ASSERT_TRUE(data.arg2->GetAsDictionary(&dictionary));
   CheckShowSyncSetupArgs(
       dictionary, "", false, GoogleServiceAuthError::SERVICE_UNAVAILABLE,
       kTestUser, true, "");
 }
+#endif  // !OS_CHROMEOS
 
 TEST_F(SyncSetupHandlerTest, TestSyncEverything) {
   std::string args =
       "{\"syncAllDataTypes\":true,"
       "\"sync_apps\":true,"
       "\"sync_autofill\":true,"
       "\"sync_bookmarks\":true,"
       "\"sync_extensions\":true,"
       "\"sync_passwords\":true,"
       "\"sync_preferences\":true,"
@@ skipping 410 matching lines @@
 
   // This should display the sync setup dialog (not login).
   handler_->OpenSyncSetup(false);
 
   ExpectConfig();
   const TestWebUI::CallData& data = web_ui_.call_data()[0];
   DictionaryValue* dictionary;
   ASSERT_TRUE(data.arg2->GetAsDictionary(&dictionary));
   CheckBool(dictionary, "encryptAllData", true);
 }