tests/standalone/src/io/HttpServerSocketTest.dart - Issue 9956062: Refactor the close and error handling of HTTP connections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/src/io/HttpServerSocketTest.dart

Issue 9956062: Refactor the close and error handling of HTTP connections (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/http_parser.dart ('K') | « tests/standalone/src/io/HttpServerEarlyServerCloseTest.dart ('k') | tests/standalone/standalone.status » ('j') | tests/standalone/standalone.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/src/io/HttpServerSocketTest.dart

diff --git a/tests/standalone/src/io/HttpServerSocketTest.dart b/tests/standalone/src/io/HttpServerSocketTest.dart

index 1339c9b22221e626d8d439b94d856e9a06d606d8..d25481010c287fa91063efc7f802f83e90a38745 100644

--- a/tests/standalone/src/io/HttpServerSocketTest.dart

+++ b/tests/standalone/src/io/HttpServerSocketTest.dart

@@ -9,7 +9,7 @@ class ExpectedDataOutputStream implements OutputStream {

ExpectedDataOutputStream(List<int> this._data,

int this._cutoff,

bool this._closeAsError,

- SocketImpl this._socket);

+ SocketMock this._socket);

Anders Johnsen 2012/04/03 05:36:37 Oops, ty!

void set onNoPendingWrites(void callback()) {

_onNoPendingWrites = callback;

@@ -49,7 +49,7 @@ class ExpectedDataOutputStream implements OutputStream {

int _written = 0;

int _cutoff;

bool _closeAsError;

- SocketImpl _socket;

+ SocketMock _socket;

}

class SocketMock implements Socket {