tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart - Issue 9956062: Refactor the close and error handling of HTTP connections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart

Issue 9956062: Refactor the close and error handling of HTTP connections (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/http_parser.dart ('K') | « tests/standalone/src/io/HttpParserTest.dart ('k') | tests/standalone/src/io/HttpServerEarlyServerCloseTest.dart » ('j') | tests/standalone/src/io/HttpServerSocketTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart

diff --git a/tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart b/tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart

index 833dce87c60c137b632efa0acf96d2bda2edfa35..439a22530d90fbea31b5a3707a0e71589e49c040 100644

--- a/tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart

+++ b/tests/standalone/src/io/HttpServerEarlyClientCloseTest.dart

@@ -58,17 +58,17 @@ void testEarlyClose() {

// The empty packet is valid.

// Close while sending header

- add("G", "Connection closed before header was received");

- add("GET /", "Failed to parse HTTP");

- add("GET / HTTP/1.1", "Failed to parse HTTP");

- add("GET / HTTP/1.1\r\n", "Failed to parse HTTP");

+ add("G", "Connection closed before full header was received");

+ add("GET /", "Connection closed before full header was received");

+ add("GET / HTTP/1.1", "Connection closed before full header was received");

+ add("GET / HTTP/1.1\r\n", "Connection closed before full header was received");

// Close while sending content

add("GET / HTTP/1.1\r\nContent-Length: 100\r\n\r\n",

- "Failed to parse HTTP",

+ "Connection closed before full body was received",

expectRequest: true);

add("GET / HTTP/1.1\r\nContent-Length: 100\r\n\r\n1",

- "Failed to parse HTTP",

+ "Connection closed before full body was received",

expectRequest: true);