boto/s3/resumable_download_handler.py - Issue 9956052: Fix checksum support to be compatible with Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: boto/s3/resumable_download_handler.py

Issue 9956052: Fix checksum support to be compatible with Windows. (Closed) Base URL: svn://svn.chromium.org/boto

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: boto/s3/resumable_download_handler.py

diff --git a/boto/s3/resumable_download_handler.py b/boto/s3/resumable_download_handler.py

index 5492e14bc726a4195283244834c64e23544df385..d7d2aa0ff3c4863cde317eca83dcaa4b5b346074 100644

--- a/boto/s3/resumable_download_handler.py

+++ b/boto/s3/resumable_download_handler.py

@@ -220,7 +220,7 @@ class ResumableDownloadHandler(object):

gsutil runs), and the user could change some of the file and not

realize they have inconsistent data.

"""

- fp = open(file_name, 'r')

+ fp = open(file_name, 'rb')

if key.bucket.connection.debug >= 1:

print 'Checking md5 against etag.'

hex_md5 = key.compute_md5(fp)[0]

« no previous file with comments | « README.chromium ('k') | no next file » | no next file with comments »