README.chromium - Issue 9956052: Fix checksum support to be compatible with Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: README.chromium

Issue 9956052: Fix checksum support to be compatible with Windows. (Closed) Base URL: svn://svn.chromium.org/boto

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 URL: http://github.com/boto/boto

	2 Version: 2.1.1

	3 License: MIT License

	4

	5 This is a forked copy of boto v2.1.1.

	6

	7

	8 Fix checksum support to be compatible with Windows.

	9 See http://bugs.python.org/issue1735418 for more info.

	10

	11 index 5492e14..d7d2aa0 100644

	12 --- a/boto/s3/resumable_download_handler.py

	13 +++ b/boto/s3/resumable_download_handler.py

	14 @@ -220,7 +220,7 @@ class ResumableDownloadHandler(object):

	15 gsutil runs), and the user could change some of the file and not

	16 realize they have inconsistent data.

	17 """

	18 - fp = open(file_name, 'r')

	19 + fp = open(file_name, 'rb')

	20 if key.bucket.connection.debug >= 1:

	21 print 'Checking md5 against etag.'

	22 hex_md5 = key.compute_md5(fp)[0]

OLD	NEW

« no previous file with comments | « no previous file | boto/s3/resumable_download_handler.py » ('j') | no next file with comments »