Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 9956049: MIPS: Increase external array allocation header size to 8 bytes. (Closed)

Created:
8 years, 8 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

MIPS: Increase external array allocation header size to 8 bytes. This fixes alignment issues on MIPS HW, found for example in mjsunit external-array. The issue originates from r11144 (86563c3e21) which adds a 4-byte header to these arrays. This causes problems on MIPS, where certain pointers need to be 8-byte aligned. BUG= TEST=mjsunit/external-array Committed: https://code.google.com/p/v8/source/detail?r=11303

Patch Set 1 #

Patch Set 2 : Set 8-byte header on all arches. #

Patch Set 3 : Rebased on r11256. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/d8.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kalmard
In case you don't like having the arch-specific define in the code, here are some ...
8 years, 8 months ago (2012-03-31 10:52:44 UTC) #1
danno
Since this is only in D8, 64-bit aligning the external buffers on architecture seems like ...
8 years, 8 months ago (2012-04-02 15:48:37 UTC) #2
kalmard
On 2012/04/02 15:48:37, danno wrote: > Since this is only in D8, 64-bit aligning the ...
8 years, 8 months ago (2012-04-03 15:11:19 UTC) #3
kalmard
Rebased on r11256.
8 years, 8 months ago (2012-04-10 15:57:18 UTC) #4
Jakob Kummerow
8 years, 8 months ago (2012-04-13 08:56:37 UTC) #5
LGTM, landing.

Powered by Google App Engine
This is Rietveld 408576698