Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 9956025: Merge 112677 - Web Inspector: ScriptsNavigator scripts selection/focus polish. (Closed)

Created:
8 years, 8 months ago by vsevik
Modified:
8 years, 8 months ago
Reviewers:
vsevik
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112677 - Web Inspector: ScriptsNavigator scripts selection/focus polish. https://bugs.webkit.org/show_bug.cgi?id=82732 Reviewed by Pavel Feldman. Script could be selected by space in ScriptsNavigator now. This patch also polishes focus behavior when using ScriptsNavigator. * inspector/front-end/ScriptsNavigator.js: (WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus. (WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed. (WebInspector.NavigatorScriptTreeElement.prototype._onclick): (WebInspector.NavigatorScriptTreeElement.prototype.onenter): * inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly. (WebInspector.ScriptsPanel.prototype._editorSelected): (WebInspector.ScriptsPanel.prototype._fileSelected): (WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay): * inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown): onspace event added. TBR=vsevik@chromium.org BUG=121133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=112684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M Source/WebCore/inspector/front-end/ScriptsNavigator.js View 2 chunks +13 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/treeoutline.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsevik
8 years, 8 months ago (2012-03-30 17:25:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698