Issue 9956024: Add OWNERS files for content/test and content/test/data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9956024: Add OWNERS files for content/test and content/test/data (Closed)

Created:
8 years, 8 months ago by tommi (sloooow) - chröme

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OWNERS files for content/test and content/test/data BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129880

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	content/test/OWNERS	View		1 chunk	+2 lines, -0 lines	1 comment	Download
	A	content/test/data/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

8 years, 8 months ago (2012-03-30 17:09:12 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9956024/diff/1/content/test/OWNERS
File content/test/OWNERS (right):

https://chromiumcodereview.appspot.com/9956024/diff/1/content/test/OWNERS#new...
content/test/OWNERS:1: # inherits owners from the parent directory.
nit: this comment is redundant (if you put it here, why not in all files? :) )

can you just say "for webrtc files"?

Expand Messages | Collapse Messages