Issue 9956020: Fix Crash in ExtensionSorting::SyncIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9956020: Fix Crash in ExtensionSorting::SyncIfNeeded (Closed)

Created:
8 years, 8 months ago by csharp

Modified:
8 years, 8 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, mihaip+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix Crash in ExtensionSorting::SyncIfNeeded Replace CHECK with if statement, since it is possible to have old extensions that have ordinal values. BUG=120978 TEST=Old profiles with extensions that have ordinal values don't crash on startup Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130040

Patch Set 1 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_sorting.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/9956020/2001

8 years, 8 months ago (2012-03-30 21:44:35 UTC) #3

commit-bot: I haz the power

Try job failure for 9956020-2001 (retry) (retry) on win_rel for step "browser_tests". It's a second ...

8 years, 8 months ago (2012-03-31 02:18:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/9956020/2001

8 years, 8 months ago (2012-03-31 02:19:48 UTC) #5

Change committed as 130040

Expand Messages | Collapse Messages