Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 99503002: appropriating Shailen's excellent Futures intro into tutorial (Closed)

Created:
7 years ago by mem
Modified:
7 years ago
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

appropriating Shailen's excellent Futures intro into tutorial BUG= R=kathyw@google.com Committed: 1c38438

Patch Set 1 #

Total comments: 6

Patch Set 2 : changes based on Kathy's feedback #

Patch Set 3 : pesky file #

Patch Set 4 : another pesky file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -645 lines) Patch
M src/appengine/app.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M src/appengine/scripts/redirector.py View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/diagrams/tutorials/futures/eventloop.graffle View 1 22 chunks +248 lines, -264 lines 0 comments Download
D src/site/articles/using-future-based-apis/code/dailyNewsDigest.txt View 1 chunk +0 lines, -1 line 0 comments Download
D src/site/articles/using-future-based-apis/code/example1.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D src/site/articles/using-future-based-apis/code/example2.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D src/site/articles/using-future-based-apis/code/example3.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D src/site/articles/using-future-based-apis/code/example4.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D src/site/articles/using-future-based-apis/code/example5.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D src/site/articles/using-future-based-apis/index.markdown View 1 chunk +0 lines, -212 lines 0 comments Download
M src/site/docs/tutorials/fetchdata/index.markdown View 1 3 chunks +15 lines, -5 lines 0 comments Download
M src/site/docs/tutorials/forms/index.markdown View 1 1 chunk +4 lines, -3 lines 0 comments Download
A src/site/docs/tutorials/futures/images/futurescode.png View 1 Binary file 0 comments Download
A + src/site/docs/tutorials/futures/index.markdown View 1 7 chunks +93 lines, -24 lines 0 comments Download
M src/site/docs/tutorials/index.markdown View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M src/site/docs/tutorials/indexeddb/index.markdown View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/site/docs/tutorials/polymer-intro/index.markdown View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mem
Moved Shailen's Futures article into the tutorials. Reformatted and made small adjustments to fit the ...
7 years ago (2013-12-02 17:07:34 UTC) #1
Kathy Walrath
I like it. But I'm not sure about the figure for the Futures tutorial. First, ...
7 years ago (2013-12-02 17:36:03 UTC) #2
Kathy Walrath
lgtm
7 years ago (2013-12-02 19:00:25 UTC) #3
mem
7 years ago (2013-12-02 19:01:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r1c38438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698