Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/WebKit/mac/WebView/WebView.mm

Issue 9950115: Revert 111028 - Support W3C Full Screen API proposal (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/dom/Element.idl ('k') | Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/mac/WebView/WebView.mm
===================================================================
--- Source/WebKit/mac/WebView/WebView.mm (revision 113078)
+++ Source/WebKit/mac/WebView/WebView.mm (working copy)
@@ -6284,9 +6284,14 @@
#if ENABLE(FULLSCREEN_API)
- (BOOL)_supportsFullScreenForElement:(const WebCore::Element*)element withKeyboard:(BOOL)withKeyboard
{
+ if (withKeyboard)
+ return NO;
+
if (![[WebPreferences standardPreferences] fullScreenEnabled])
return NO;
+ // FIXME: If the element is in an IFrame, we should ensure it has
+ // an AllowsFullScreen=YES attribute before allowing fullscreen access.
return YES;
}
« no previous file with comments | « Source/WebCore/dom/Element.idl ('k') | Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698