Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 9950048: Reduce initial boot-up memory use. This is an other attempt at what (Closed)

Created:
8 years, 8 months ago by Erik Corry
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reduce initial boot-up memory use. This is an other attempt at what http://codereview.chromium.org/9179012 was trying to achieve. This time I am going for 80% of the benefit with around 5% of the complexity. It works by reducing the size of the first page in each space. Unlike the previous change there is no attempt to grow pages, we just allocate more full-sized pages when we need more memory. For this reason the first pages are not quite as small (compare http://codereview.chromium.org/9179012/diff/1/src/snapshot.h with the changes in spaces.cc in this cl): We want to be able to do a little bit of allocation before we have to add a full-sized page to the space. Committed: https://code.google.com/p/v8/source/detail?r=11203

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M src/spaces.h View 3 chunks +6 lines, -1 line 1 comment Download
M src/spaces.cc View 6 chunks +45 lines, -8 lines 2 comments Download
M src/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 8 months ago (2012-04-01 18:17:43 UTC) #1
Michael Starzinger
8 years, 8 months ago (2012-04-02 08:25:05 UTC) #2
LGTM. I am positively surprised that it is that easy to change the size of one
page. I would have assumed it would break everything instantly if one tries
that.

http://codereview.chromium.org/9950048/diff/1/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/9950048/diff/1/src/spaces.cc#newcode872
src/spaces.cc:872: size = 64 * sizeof(dummy) * KB;
Why not use kPointerSize here?

http://codereview.chromium.org/9950048/diff/1/src/spaces.cc#newcode884
src/spaces.cc:884: if (sizeof(dummy) == 8) {
Why not use kPointerSize here?

http://codereview.chromium.org/9950048/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/9950048/diff/1/src/spaces.h#newcode959
src/spaces.h:959: Executability executable,
I know you didn't touch that line, but something is wrong with indentation here.

Powered by Google App Engine
This is Rietveld 408576698