chrome/common/extensions/api/extension_api.cc - Issue 9950039: Revert r12998 - it broke some media/mime-related layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 9950039: Revert r12998 - it broke some media/mime-related layout tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/extension_api.cc

diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc

index 3178975fc93f178669e33f6cd40577b1fa872fb2..6bbd8df4d10f4419533e0658b0717b8847ea061b 100644

--- a/chrome/common/extensions/api/extension_api.cc

+++ b/chrome/common/extensions/api/extension_api.cc

@@ -268,12 +268,10 @@ bool ExtensionAPI::IsPrivileged(const std::string& full_name) {

std::vector<std::string> split;

base::SplitString(full_name, '.', &split);

std::reverse(split.begin(), split.end());

- CHECK(!split.empty()); // |full_name| was empty or only whitespace.

api_name = split.back();

split.pop_back();

if (api_name == "experimental") {

- CHECK(!split.empty()); // |full_name| was "experimental" alone.

api_name += "." + split.back();

split.pop_back();

}