Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: lib/html/src/dartium_FactoryProviders.dart

Issue 9950037: Fix factory dart:html typed array providers for dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: suppress html/TypedArrays tests in ie Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/frog/html_frog.dart ('k') | lib/html/src/frog_FactoryProviders.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/src/dartium_FactoryProviders.dart
diff --git a/lib/html/src/dartium_FactoryProviders.dart b/lib/html/src/dartium_FactoryProviders.dart
index d5227e8870c98ad4c8e77dcaccef91e5d4fa63d8..0cfc32ccabadee64296ff75d5f68e7465efec898 100644
--- a/lib/html/src/dartium_FactoryProviders.dart
+++ b/lib/html/src/dartium_FactoryProviders.dart
@@ -10,39 +10,75 @@ class _TypedArrayFactoryProvider {
factory Float32Array(int length) => _F32(length);
factory Float32Array.fromList(List<num> list) => _F32(ensureNative(list));
- factory Float32Array.fromBuffer(ArrayBuffer buffer) => _F32(buffer);
+ factory Float32Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _F32_2(buffer, byteOffset);
+ return _F32_3(buffer, byteOffset, length);
+ }
factory Float64Array(int length) => _F64(length);
factory Float64Array.fromList(List<num> list) => _F64(ensureNative(list));
- factory Float64Array.fromBuffer(ArrayBuffer buffer) => _F64(buffer);
+ factory Float64Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _F64_2(buffer, byteOffset);
+ return _F64_3(buffer, byteOffset, length);
+ }
factory Int8Array(int length) => _I8(length);
factory Int8Array.fromList(List<num> list) => _I8(ensureNative(list));
- factory Int8Array.fromBuffer(ArrayBuffer buffer) => _I8(buffer);
+ factory Int8Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _I8_2(buffer, byteOffset);
+ return _I8_3(buffer, byteOffset, length);
+ }
factory Int16Array(int length) => _I16(length);
factory Int16Array.fromList(List<num> list) => _I16(ensureNative(list));
- factory Int16Array.fromBuffer(ArrayBuffer buffer) => _I16(buffer);
+ factory Int16Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _I16_2(buffer, byteOffset);
+ return _I16_3(buffer, byteOffset, length);
+ }
factory Int32Array(int length) => _I32(length);
factory Int32Array.fromList(List<num> list) => _I32(ensureNative(list));
- factory Int32Array.fromBuffer(ArrayBuffer buffer) => _I32(buffer);
+ factory Int32Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _I32_2(buffer, byteOffset);
+ return _I32_3(buffer, byteOffset, length);
+ }
factory Uint8Array(int length) => _U8(length);
factory Uint8Array.fromList(List<num> list) => _U8(ensureNative(list));
- factory Uint8Array.fromBuffer(ArrayBuffer buffer) => _U8(buffer);
+ factory Uint8Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _U8_2(buffer, byteOffset);
+ return _U8_3(buffer, byteOffset, length);
+ }
factory Uint16Array(int length) => _U16(length);
factory Uint16Array.fromList(List<num> list) => _U16(ensureNative(list));
- factory Uint16Array.fromBuffer(ArrayBuffer buffer) => _U16(buffer);
+ factory Uint16Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _U16_2(buffer, byteOffset);
+ return _U16_3(buffer, byteOffset, length);
+ }
factory Uint32Array(int length) => _U32(length);
factory Uint32Array.fromList(List<num> list) => _U32(ensureNative(list));
- factory Uint32Array.fromBuffer(ArrayBuffer buffer) => _U32(buffer);
+ factory Uint32Array.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _U32_2(buffer, byteOffset);
+ return _U32_3(buffer, byteOffset, length);
+ }
factory Uint8ClampedArray(int length) => _U8C(length);
factory Uint8ClampedArray.fromList(List<num> list) => _U8C(ensureNative(list));
- factory Uint8ClampedArray.fromBuffer(ArrayBuffer buffer) => _U8C(buffer);
+ factory Uint8ClampedArray.fromBuffer(ArrayBuffer buffer,
+ [int byteOffset = 0, int length]) {
+ if (length == null) return _U8C_2(buffer, byteOffset);
+ return _U8C_3(buffer, byteOffset, length);
+ }
static Float32Array _F32(arg) => _wrap(new dom.Float32Array(arg));
static Float64Array _F64(arg) => _wrap(new dom.Float64Array(arg));
@@ -54,6 +90,26 @@ class _TypedArrayFactoryProvider {
static Uint32Array _U32(arg) => _wrap(new dom.Uint32Array(arg));
static Uint8ClampedArray _U8C(arg) => _wrap(new dom.Uint8ClampedArray(arg));
+ static Float32Array _F32_2(arg1, arg2) => _wrap(new dom.Float32Array(arg1, arg2));
+ static Float64Array _F64_2(arg1, arg2) => _wrap(new dom.Float64Array(arg1, arg2));
+ static Int8Array _I8_2(arg1, arg2) => _wrap(new dom.Int8Array(arg1, arg2));
+ static Int16Array _I16_2(arg1, arg2) => _wrap(new dom.Int16Array(arg1, arg2));
+ static Int32Array _I32_2(arg1, arg2) => _wrap(new dom.Int32Array(arg1, arg2));
+ static Uint8Array _U8_2(arg1, arg2) => _wrap(new dom.Uint8Array(arg1, arg2));
+ static Uint16Array _U16_2(arg1, arg2) => _wrap(new dom.Uint16Array(arg1, arg2));
+ static Uint32Array _U32_2(arg1, arg2) => _wrap(new dom.Uint32Array(arg1, arg2));
+ static Uint8ClampedArray _U8C_2(arg1, arg2) => _wrap(new dom.Uint8ClampedArray(arg1, arg2));
+
+ static Float32Array _F32_3(arg1, arg2, arg3) => _wrap(new dom.Float32Array(arg1, arg2, arg3));
+ static Float64Array _F64_3(arg1, arg2, arg3) => _wrap(new dom.Float64Array(arg1, arg2, arg3));
+ static Int8Array _I8_3(arg1, arg2, arg3) => _wrap(new dom.Int8Array(arg1, arg2, arg3));
+ static Int16Array _I16_3(arg1, arg2, arg3) => _wrap(new dom.Int16Array(arg1, arg2, arg3));
+ static Int32Array _I32_3(arg1, arg2, arg3) => _wrap(new dom.Int32Array(arg1, arg2, arg3));
+ static Uint8Array _U8_3(arg1, arg2, arg3) => _wrap(new dom.Uint8Array(arg1, arg2, arg3));
+ static Uint16Array _U16_3(arg1, arg2, arg3) => _wrap(new dom.Uint16Array(arg1, arg2, arg3));
+ static Uint32Array _U32_3(arg1, arg2, arg3) => _wrap(new dom.Uint32Array(arg1, arg2, arg3));
+ static Uint8ClampedArray _U8C_3(arg1, arg2, arg3) => _wrap(new dom.Uint8ClampedArray(arg1, arg2, arg3));
+
static ensureNative(List list) => list; // TODO: make sure.
}
« no previous file with comments | « lib/html/frog/html_frog.dart ('k') | lib/html/src/frog_FactoryProviders.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698