Renamed the 'dartc' launch script to 'dart-analysis' and adds it to dart-sdk

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 366 matching lines @@
       // rest. They use the .dart suffix in the status files. They
       // find tests in weird ways (testing that they contain "#").
       // They need to be redone.
       // TODO(1058): This does not work on Windows.
       start = filename.indexOf(directoryPath);
       if (start != -1) {
         testName = filename.substring(start + directoryPath.length + 1);
       } else {
         testName = filename;
       }
-
-      if (configuration['compiler'] != 'dartc' ||
+      String suffix = TestUtils.executableSuffix(configuration['compiler']);
+      if (configuration['compiler'] != 'dart_analyzer$suffix' ||
           testName.endsWith('_test.dart')) {

[Bill Hesse, 2012/06/12 12:19:46]

I looked at this a couple of weeks ago, and came to the conclusion that there
were no tests run with dart_analyzer that did not end in _test.dart, so this
guard could be removed.  It would be great, and really simplify things, if it
could be.

If there are any tests that still hit this guard, couldn't we update their
status file entries to not use .dart?

Let's get rid of this (and I will then be able to use the new Path library
better in the enclosing code).

         if (testName.endsWith('.dart')) {
           testName = testName.substring(0, testName.length - 5);
         }
       }
     }
     int shards = configuration['shards'];
     if (shards > 1) {
       int shard = configuration['shard'];
       if (testName.hashCode() % shards != shard - 1) {
         return;
@@ skipping 720 matching lines @@
                         completeHandler,
                         new Set<String>.from([PASS])));
     doDone();
   }
 
   void completeHandler(TestCase testCase) {
   }
 
   void computeClassPath() {
     classPath = Strings.join(
-        ['$buildDir/compiler/lib/dartc.jar',
-         '$buildDir/compiler-tests.jar',
-         '$buildDir/closure_out/compiler.jar',
+        ['$buildDir/analyzer/util/analyzer/dart_analyzer.jar',
+         '$buildDir/analyzer/dart_analyzer_tests.jar',
          // Third party libraries.
          '$dartDir/third_party/args4j/2.0.12/args4j-2.0.12.jar',
          '$dartDir/third_party/guava/r09/guava-r09.jar',
          '$dartDir/third_party/rhino/1_7R3/js.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-core-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-generator-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-integration-1.3.0RC2.jar',
          '$dartDir/third_party/hamcrest/v1_3/hamcrest-library-1.3.0RC2.jar',
          '$dartDir/third_party/junit/v4_8_2/junit.jar'],
         ':');  // Path separator.
@@ skipping 43 matching lines @@
     }
     return '';
   }
 
   static String executableName(Map configuration) {
     String suffix = executableSuffix(configuration['compiler']);
     switch (configuration['compiler']) {
       case 'none':
         return 'dart$suffix';
       case 'dartc':
-        return 'compiler/bin/dartc$suffix';
+        return 'analyzer/bin/dart_analyzer$suffix';
       case 'dart2js':
         var prefix = '';
         if (configuration['use_sdk']) {
           prefix = 'dart-sdk/bin/';
         }
         if (configuration['host_checked']) {
           // The script dart2js_developer is not in the SDK.
           return 'dart2js_developer$suffix';
         } else {
           return '${prefix}dart2js$suffix';
@@ skipping 151 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }