Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 9950011: Revert 129779 - Limit Chrome To Mobile cloud print access; refinements etc. (Closed)

Created:
8 years, 8 months ago by msw
Modified:
8 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 129779 - Limit Chrome To Mobile cloud print access; refinements etc. Check the user's account info before contacting cloud print. Only ping cloud print for users of that service. Make ChromeToMobileService a RefcountedProfileKeyedService. Add and check |temp_dir_valid_| on GenerateSnapshot. Fix a JSON DictionaryValue leak from ParseResponseJSON use. Make |mobiles_| a ScopedVector of DeepCopy DictionaryValues. Call new ChromeToMobileService::HasDevices for encapsulation. Call RequestMobileListUpdate from bubbles, not their callers. Mock RequestMobileListUpdate so tests do not send requests. Store the service, not the profile, as a bubble class member. Skip IsSyncAccessible on updates (the first check suffices). Auto-close on Mac via performSelector, not PostDelayedTask. cancelPreviousPerformRequestsWithTarget on windowWillClose. Call OnChanged after UpdateChromeToMobileEnabled for Mac. (the icon wasn't showing up immediately on Release builds) BUG=102709, 118691 TEST=Less cloud print traffic. No apparent behavior changes. Review URL: https://chromiumcodereview.appspot.com/9863054 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -180 lines) Patch
M chrome/browser/chrome_to_mobile_service.h View 7 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 14 chunks +29 lines, -99 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller_unittest.mm View 6 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
8 years, 8 months ago (2012-03-30 04:35:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698