Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9949069: Fix cut/paste on the same volume. (Closed)

Created:
8 years, 8 months ago by SeRya
Modified:
8 years, 8 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix cut/paste on the same volume. BUG=chromium-os:29378 TEST=Cut 2 or more files. Paste them into another folder of the same volume. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132379

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 1 6 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
SeRya
8 years, 8 months ago (2012-04-16 06:46:27 UTC) #1
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/9949069/diff/1/chrome/browser/resources/file_manager/js/file_copy_manager.js File chrome/browser/resources/file_manager/js/file_copy_manager.js (right): https://chromiumcodereview.appspot.com/9949069/diff/1/chrome/browser/resources/file_manager/js/file_copy_manager.js#newcode446 chrome/browser/resources/file_manager/js/file_copy_manager.js:446: var sourceAndTargetOnGData = task.sourceOnGData && task.targetOnGData; Looks like this ...
8 years, 8 months ago (2012-04-16 06:55:45 UTC) #2
SeRya
http://codereview.chromium.org/9949069/diff/1/chrome/browser/resources/file_manager/js/file_copy_manager.js File chrome/browser/resources/file_manager/js/file_copy_manager.js (right): http://codereview.chromium.org/9949069/diff/1/chrome/browser/resources/file_manager/js/file_copy_manager.js#newcode446 chrome/browser/resources/file_manager/js/file_copy_manager.js:446: var sourceAndTargetOnGData = task.sourceOnGData && task.targetOnGData; On 2012/04/16 06:55:45, ...
8 years, 8 months ago (2012-04-16 07:05:28 UTC) #3
Vladislav Kaznacheev
8 years, 8 months ago (2012-04-16 07:11:57 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698