Show CWS and FileManager icons in pinned apps

Show CWS and FileManager icons in pinned apps

BUG=120471
TEST=manual

[sky, 2012-04-05 16:30:50]

https://chromiumcodereview.appspot.com/9949012/diff/1/chrome/browser/ui/views...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc (right):

https://chromiumcodereview.appspot.com/9949012/diff/1/chrome/browser/ui/views...
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc:365: //
ExtensionIconSource that knows how to work with component extensions.
Why doesn't ImageLoadingTracker work for this? If we need to hack these special
cases, shouldn't it be done in ImageLoadingTracker?

[Dmitry Polukhin, 2012-04-05 17:11:08]

https://chromiumcodereview.appspot.com/9949012/diff/1/chrome/browser/ui/views...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc (right):

https://chromiumcodereview.appspot.com/9949012/diff/1/chrome/browser/ui/views...
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc:365: //
ExtensionIconSource that knows how to work with component extensions.
On 2012/04/05 16:30:50, sky wrote:
> Why doesn't ImageLoadingTracker work for this? If we need to hack these
special
> cases, shouldn't it be done in ImageLoadingTracker?
 
Good suggestion! I'll move similar code from ExtensionIconSource and here to 
ImageLoadingTracker. It might be even be good enough long term solution and
should be just a bit more complex than this hack.

[Dmitry Polukhin, 2012-04-06 12:36:13]

PTAL

Unfortunately move all logic for component extensions from ExtensionIconSource
to ImageLoadingTracker is not very easy so I would prefer to don't make it in
this CL because it is going to be merge to M19.

[sky, 2012-04-06 16:16:40]

I'm not an owner for this area and I'm not sure that Finnur is either.

Also, I would tend to go for the right fix and worry about the merge later, but
that's just me.

[Mihai Parparita -not on Chrome, 2012-04-06 23:03:23]

Perhaps I'm missing something, but it looks like
https://chromiumcodereview.appspot.com/9979001/ fixes this too, and in a better
way.

[Dmitry Polukhin, 2012-04-07 05:51:49]

I haven't seen it but yes it partially fixes issue (i.e. fixes file manager
icon) but for CWS icon we need explicit check that remains in
ExtensionIconSource (see ExtensionIconSource::GetWebStoreImage). It is very sad
that 3 of us fixing the same bug from different angles. I'll rebase and add code
for CWS icon also there is no sense to make ImageLoadingTracker depending on
ExtensionIconSource (dependence should be only in opposite direction) (they
depends after the 9979001 due to ExtensionIconSource::LoadImageByResourceId.

[Dmitry Polukhin, 2012-04-09 12:34:30]

Abandon this patch because another CL picked up relevant parts
https://chromiumcodereview.appspot.com/9979001/