Chromium Code Reviews| Index: tools/testing/dart/test_runner.dart |
| =================================================================== |
| --- tools/testing/dart/test_runner.dart (revision 6005) |
| +++ tools/testing/dart/test_runner.dart (working copy) |
| @@ -208,6 +208,11 @@ |
| Duration time; |
| List<String> diagnostics; |
| + /* A flag to indicate we have already printed a warning about ignoring the VM |
|
Siggi Cherem (dart-lang)
2012/03/30 01:01:24
nit: use the style from all other comments
/**
*
|
| + * crash, to limit the amount of output produced per test. |
| + */ |
| + bool alreadyPrintedWarning = false; |
| + |
| /** |
| * Set to true if we encounter a condition in the output that indicates we |
| * need to rerun this test. |
| @@ -271,12 +276,12 @@ |
| if (new Platform().operatingSystem() == 'windows' && exitCode == 253) { |
| for (String line in testCase.output.stdout) { |
| if (line.startsWith('VM exited with signal 1073741819')) { |
| - print("WARNING: VM crashed on this test with signal 1073741819. " + |
| - "This is a fake pass!!"); |
| - if (testCase.expectedOutcomes.iterator().hasNext()) { |
| - return testCase.expectedOutcomes.iterator().next() == FAIL ? false : |
| - true; |
| + if (!alreadyPrintedWarning) { |
| + print("WARNING: VM crashed on this test with signal 1073741819. " + |
| + "This is a fake pass!!"); |
| + alreadyPrintedWarning = true; |
| } |
| + return false; |
|
Siggi Cherem (dart-lang)
2012/03/30 01:01:24
should we use: return !testCase.isNegative;
|
| } |
| } |
| } |