Fix issue http://code.google.com/p/dart/issues/detail?id=1877 without degrading performance. Impro…

client/tests/client/html/ElementTests.dart

Index: client/tests/client/html/ElementTests.dart
diff --git a/client/tests/client/html/ElementTests.dart b/client/tests/client/html/ElementTests.dart
index a049b698a9a480583af7539447354be1d34e7f3e..96d0f4b1ce07b5066f59a35115255a4d007e2fbd 100644
--- a/client/tests/client/html/ElementTests.dart
+++ b/client/tests/client/html/ElementTests.dart
@@ -412,38 +412,48 @@ void testElement() {
         (listener) => Testing.addEventListener(element,
             'webkitfullscreenchange', listener, true));
   });
+ 
+  group('attributes', () {
+      test('manipulation', () {
+        final element = new Element.html(
+            '''<div class="foo" style="overflow: hidden" data-foo="bar"
+                   data-foo2="bar2" dir="rtl">
+               </div>''');
+        final attributes = element.attributes;
+        Expect.equals(attributes['class'], 'foo');
+        Expect.equals(attributes['style'], 'overflow: hidden');
+        Expect.equals(attributes['data-foo'], 'bar');
+        Expect.equals(attributes['data-foo2'], 'bar2');
+        Expect.equals(attributes.length, 5);
+        Expect.equals(element.dataAttributes.length, 2);
+        element.dataAttributes['foo'] = 'baz';
+        Expect.equals(element.dataAttributes['foo'], 'baz');
+        Expect.equals(attributes['data-foo'], 'baz');
+        attributes['data-foo2'] = 'baz2';
+        Expect.equals(attributes['data-foo2'], 'baz2');
+        Expect.equals(element.dataAttributes['foo2'], 'baz2');
+        Expect.equals(attributes['dir'], 'rtl');
+
+        final dataAttributes = element.dataAttributes;
+        dataAttributes.remove('foo2');
+        Expect.equals(attributes.length, 4);
+        Expect.equals(dataAttributes.length, 1);
+        attributes.remove('style');
+        Expect.equals(attributes.length, 3);
+        dataAttributes['foo3'] = 'baz3';
+        Expect.equals(dataAttributes.length, 2);
+        Expect.equals(attributes.length, 4);
+        attributes['style'] = 'width: 300px;';
+        Expect.equals(attributes.length, 5);
+      });
 
-  test('attributes', () {
-    final element = new Element.html(
-        '''<div class="foo" style="overflow: hidden" data-foo="bar"
-               data-foo2="bar2" dir="rtl">
-           </div>''');
-    final attributes = element.attributes;
-    Expect.equals(attributes['class'], 'foo');
-    Expect.equals(attributes['style'], 'overflow: hidden');
-    Expect.equals(attributes['data-foo'], 'bar');
-    Expect.equals(attributes['data-foo2'], 'bar2');
-    Expect.equals(attributes.length, 5);
-    Expect.equals(element.dataAttributes.length, 2);
-    element.dataAttributes['foo'] = 'baz';
-    Expect.equals(element.dataAttributes['foo'], 'baz');
-    Expect.equals(attributes['data-foo'], 'baz');
-    attributes['data-foo2'] = 'baz2';
-    Expect.equals(attributes['data-foo2'], 'baz2');
-    Expect.equals(element.dataAttributes['foo2'], 'baz2');
-    Expect.equals(attributes['dir'], 'rtl');
-
-    // TODO(jacobr): determine why these tests are causing segfaults in dartium
-    // element.dataAttributes.remove('foo2');
-    // Expect.equals(attributes.length, 4);
-    // Expect.equals(dataAttributes.length, 1);
-    // attributes.remove('style');
-    // Expect.equals(attributes.length, 3);
-    // element.dataAttributes['foo3'] = 'baz3';
-    // Expect.equals(dataAttributes.length, 2);
-    // Expect.equals(attributes.length, 4);
-    // attributes['style'] = 'width: 300px;';
-    // Expect.equals(attributes.length, 5);*/
+      test('coersion', () {

[nweiz, 2012/03/30 00:06:23]

coercion

[Jacob, 2012/03/30 00:40:53]

Done.

+        final element = new Element.tag('div');
+        element.attributes['foo'] = 42;
+        element.attributes['bar'] = 3.1;
+        Expect.equals(element.attributes['foo'], '42');
+        Expect.equals(element.attributes['bar'], '3.1');
+      });
   });
 
   group('elements', () {