Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: lib/compiler/implementation/universe.dart

Issue 9930005: Use default values of named arguments when invoking the default super constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Report bad static calls with position (regression fix). Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/universe.dart
diff --git a/lib/compiler/implementation/universe.dart b/lib/compiler/implementation/universe.dart
index e989efaab923cfe685d5e2621b1872e0b2699496..132b2622056e1117307a85c26b3960201750283a 100644
--- a/lib/compiler/implementation/universe.dart
+++ b/lib/compiler/implementation/universe.dart
@@ -119,11 +119,11 @@ class Selector implements Hashable {
* Returns [:true:] if the selector and the [element] match; [:false:]
* otherwise.
*/
- bool addSendArgumentsToList(Send send,
- List list,
- FunctionParameters parameters,
- compileArgument(Node argument),
- compileConstant(Element element)) {
+ bool addArgumentsToList(Link<Node> arguments,
+ List list,
+ FunctionParameters parameters,
+ compileArgument(Node argument),
+ compileConstant(Element element)) {
void addMatchingSendArgumentsToList(Link<Node> link) {
for (; !link.isEmpty(); link = link.tail) {
list.add(compileArgument(link.head));
@@ -132,7 +132,7 @@ class Selector implements Hashable {
if (!this.applies(parameters)) return false;
if (this.positionalArgumentCount == parameters.parameterCount) {
- addMatchingSendArgumentsToList(send.arguments);
+ addMatchingSendArgumentsToList(arguments);
ngeoffray 2012/04/16 12:24:02 addMatchingSendArgumentsToList -> addMatchingArgum
floitsch 2012/04/16 14:23:14 Inlined the function.
return true;
}
@@ -140,7 +140,6 @@ class Selector implements Hashable {
// expected by the called function, which is the source order.
// Visit positional arguments and add them to the list.
- Link<Node> arguments = send.arguments;
int positionalArgumentCount = this.positionalArgumentCount;
for (int i = 0;
i < positionalArgumentCount;

Powered by Google App Engine
This is Rietveld 408576698