Use default values of named arguments when invoking the default super constructor.

lib/compiler/implementation/compile_time_constants.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Constant implements Hashable {
   const Constant();
 
   bool isNull() => false;
   bool isBool() => false;
   bool isTrue() => false;
@@ skipping 929 matching lines @@
       if (folded === null) error(send);
       return folded;
     }
     return super.visitSend(send);
   }
 
   visitSendSet(SendSet node) {
     error(node);
   }
 
-  /** Returns the list of constants that are passed to the static function. */
-  List<Constant> evaluateArgumentsToConstructor(Send send,
+  /**
+    * Returns the list of constants that are passed to the static function.
+    * Retruns [:null:] if the [target] does not apply to the selector.

[karlklose, 2012/04/12 13:33:51]

Retruns -> returns.

[floitsch, 2012/04/16 14:23:14]

As discussed now asserts that it succeeded. So never returns null.

+    */
+  List<Constant> evaluateArgumentsToConstructor(Selector selector,
+                                                Link<Node> arguments,
                                                 FunctionElement target) {
     FunctionParameters parameters = target.computeParameters(compiler);
-    List<Constant> arguments = <Constant>[];
-    Selector selector = elements.getSelector(send);
+    List<Constant> compiledArguments = <Constant>[];
 
     Function compileArgument = evaluate;
     Function compileConstant = compiler.compileVariable;
-    bool succeeded = selector.addSendArgumentsToList(
-        send, arguments, parameters, compileArgument, compileConstant);
-    if (!succeeded) error(send);
-    return arguments;
+    bool succeeded = selector.addArgumentsToList(arguments, compiledArguments,
+                                                 parameters, compileArgument,
+                                                 compileConstant);
+    if (!succeeded) return null;
+    return compiledArguments;
   }
 
   Constant visitNewExpression(NewExpression node) {
     if (!node.isConst()) error(node);
 
-    FunctionElement constructor = elements[node.send];
+    Send send = node.send;
+    FunctionElement constructor = elements[send];
     ClassElement classElement = constructor.enclosingElement;
     if (classElement.isInterface()) {
       compiler.resolver.resolveMethodElement(constructor);
       constructor = constructor.defaultImplementation;
       classElement = constructor.enclosingElement;
     }
 
+    Selector selector = elements.getSelector(send);
     List<Constant> arguments =
-        evaluateArgumentsToConstructor(node.send, constructor);
+        evaluateArgumentsToConstructor(selector, send.arguments, constructor);
+    if (arguments === null) error(node);
     ConstructorEvaluator evaluator =
         new ConstructorEvaluator(constructor, compiler);
     evaluator.evaluateConstructorFieldValues(arguments);
     List<Constant>jsNewArguments = evaluator.buildJsNewArguments(classElement);

[karlklose, 2012/04/12 13:33:51]

Not your code, but please add a space between variable type and name, even
though it makes the line exceeds the limit. 

[floitsch, 2012/04/16 14:23:14]

Done.

 
     compiler.registerInstantiatedClass(classElement);
     // TODO(floitsch): take generic types into account.
     Type type = classElement.computeType(compiler);
     Constant constant = new ConstructedConstant(type, jsNewArguments);
     compiler.constantHandler.registerCompileTimeConstant(constant);
     return constant;
   }
 
   Constant visitParenthesizedExpression(ParenthesizedExpression node) {
@@ skipping 44 matching lines @@
     parameters.forEachParameter((Element parameter) {
       Constant argument = arguments[index++];
       definitions[parameter] = argument;
       if (parameter.kind == ElementKind.FIELD_PARAMETER) {
         FieldParameterElement fieldParameterElement = parameter;
         fieldValues[fieldParameterElement.fieldElement] = argument;
       }
     });    
   }
 
-  void evaluateSuperOrRedirectSend(FunctionElement targetConstructor,
-                                   List<Constant> targetArguments) {
+  /** Returns, if the [targetConstructor] applies to the [selector]. */
+  bool evaluateSuperOrRedirectSend(Selector selector,
+                                   Link<Node> arguments,
+                                   FunctionElement targetConstructor) {
+    List<Constant> compiledArguments =
+        evaluateArgumentsToConstructor(selector, arguments, targetConstructor);
+    if (arguments === null) return false;

[karlklose, 2012/04/12 13:33:51]

arguments -> compiledArguments? Remove?

[floitsch, 2012/04/16 14:23:14]

removed.

+
     ConstructorEvaluator evaluator =
         new ConstructorEvaluator(targetConstructor, compiler);
-    evaluator.evaluateConstructorFieldValues(targetArguments);
+    evaluator.evaluateConstructorFieldValues(compiledArguments);
     // Copy over the fieldValues from the super/redirect-constructor.
     evaluator.fieldValues.forEach((key, value) => fieldValues[key] = value);
+    return true;
   }
 
   /**
    * Runs through the initializers of the given [constructor] and updates
    * the [fieldValues] map.
    */
   void evaluateConstructorInitializers() {
     FunctionExpression functionNode = constructor.parseNode(compiler);
     NodeList initializerList = functionNode.initializers;
 
     bool foundSuperOrRedirect = false;
 
     if (initializerList !== null) {
       for (Link<Node> link = initializerList.nodes;
            !link.isEmpty();
            link = link.tail) {
         assert(link.head is Send);
         if (link.head is !SendSet) {
           // A super initializer or constructor redirection.
           Send call = link.head;
           FunctionElement targetConstructor = elements[call];
-          List<Constant> targetArguments =
-              evaluateArgumentsToConstructor(call, targetConstructor);
-          evaluateSuperOrRedirectSend(targetConstructor, targetArguments);
+          Selector selector = elements.getSelector(call);
+          Link<Node> arguments = call.arguments;
+          bool succeeded = evaluateSuperOrRedirectSend(selector, arguments,
+                                                       targetConstructor);
+          if (!succeeded) error(call);
           foundSuperOrRedirect = true;
         } else {
           // A field initializer.
           SendSet init = link.head;
           Link<Node> initArguments = init.arguments;
           assert(!initArguments.isEmpty() && initArguments.tail.isEmpty());
           Constant fieldValue = evaluate(initArguments.head);
           fieldValues[elements[init]] = fieldValue;
         }
       }
     }
 
     if (!foundSuperOrRedirect) {
       // No super initializer found. Try to find the default constructor if
       // the class is not Object.
       ClassElement enclosingClass = constructor.enclosingElement;
       ClassElement superClass = enclosingClass.superclass;
       if (enclosingClass != compiler.objectClass) {
         assert(superClass !== null);
         assert(superClass.isResolved);
         FunctionElement targetConstructor =
             superClass.lookupConstructor(superClass.name);
         if (targetConstructor === null) {
-          compiler.internalError("no default constructor available");
+          compiler.internalError("no default constructor available",
+                                 node: functionNode);
         }
-        evaluateSuperOrRedirectSend(targetConstructor, const <Constant>[]);
+
+        bool succeeded = evaluateSuperOrRedirectSend(Selector.INVOCATION_0,
+                                                     const EmptyLink<Node>(),
+                                                     targetConstructor);
+        if (!succeeded) error(functionNode);
       }
     }
   }
 
   /**
    * Simulates the execution of the [constructor] with the given
    * [arguments] to obtain the field values that need to be passed to the
    * native JavaScript constructor.
    */
   void evaluateConstructorFieldValues(List<Constant> arguments) {
@@ skipping 12 matching lines @@
       Constant fieldValue = fieldValues[field];
       if (fieldValue === null) {
         // Use the default value.
         fieldValue = compiler.compileVariable(field);
       }
       jsNewArguments.add(fieldValue);          
     });
     return jsNewArguments;
   }
 }