Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: runtime/vm/native_message_handler.h

Issue 9924015: Use the ThreadPool for all isolates and native ports. Previously, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/native_message_handler.h
===================================================================
--- runtime/vm/native_message_handler.h (revision 5987)
+++ runtime/vm/native_message_handler.h (working copy)
@@ -6,7 +6,7 @@
#define VM_NATIVE_MESSAGE_HANDLER_H_
#include "include/dart_api.h"
-#include "vm/message.h"
+#include "vm/message_handler.h"
namespace dart {
@@ -20,6 +20,8 @@
const char* name() const { return name_; }
Dart_NativeMessageHandler func() const { return func_; }
+ bool HandleMessage(Message* message);
+
#if defined(DEBUG)
// Check that it is safe to access this handler.
void CheckAccess();
@@ -28,15 +30,6 @@
// Delete this handlers when its last live port is closed.
virtual bool OwnedByPortMap() const { return true; }
- // Start a worker thread which will service messages for this handler.
- //
- // TODO(turnidge): Instead of starting a worker for each
- // NativeMessageHandler, we should instead use a shared thread pool
- // which services a queue of ready MessageHandlers. If we implement
- // this correctly, the same pool will work for
- // IsolateMessageHandlers as well.
- void StartWorker();
-
private:
char* name_;
Dart_NativeMessageHandler func_;

Powered by Google App Engine
This is Rietveld 408576698