Use the ThreadPool for all isolates and native ports. Previously,

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 753 matching lines @@
     Dart_MessageNotifyCallback message_notify_callback) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   isolate->set_message_notify_callback(message_notify_callback);
 }
 
 
 DART_EXPORT Dart_Handle Dart_RunLoop() {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
-  const Object& obj = Object::Handle(isolate, isolate->StandardRunLoop());
+  {
+    SetIsolateScope set_scope(NULL);

[siva, 2012/04/14 00:29:53]

Why is NULL passed in and not isolate? Won't it end up setting current isolate
to NULL?

[turnidge, 2012/04/17 23:46:55]

Yeah.  When I call RunBlocking, it actually runs the isolate on another thread
and uses a monitor to tell me when it is done.  It seemed correct to give up the
current isolate before we started to execute it in a different thread.

I have added assertions in RunBlocking that there is no current isolate when
these functions are called.

[turnidge, 2012/04/17 23:49:21]

These comments are out of date, now that I've removed RunBlocking.

+    isolate->message_handler()->RunBlocking(Dart::thread_pool(), NULL, NULL);
+  }
+  const Object& obj = Object::Handle(isolate->object_store()->sticky_error());
+  isolate->object_store()->clear_sticky_error();
   if (obj.IsError()) {
     return Api::NewHandle(isolate, obj.raw());
   }
   ASSERT(obj.IsNull());
   return Api::Success(isolate);
 }
 
 
-static RawInstance* DeserializeMessage(Isolate* isolate, void* data) {
-  // Create a snapshot object using the buffer.
-  const Snapshot* snapshot = Snapshot::SetupFromBuffer(data);
-  ASSERT(snapshot->IsMessageSnapshot());
-
-  // Read object back from the snapshot.
-  SnapshotReader reader(snapshot, isolate);
-  Instance& instance = Instance::Handle(isolate);
-  instance ^= reader.ReadObject();
-  return instance.raw();
-}
-
-
 DART_EXPORT Dart_Handle Dart_HandleMessage() {
   Isolate* isolate = Isolate::Current();
-  // Process all OOB messages and at most one normal message.
-  Message* message = NULL;
-  Message::Priority priority = Message::kNormalPriority;
-  do {
-    DARTSCOPE(isolate);
-    // TODO(turnidge): This code is duplicated elsewhere.  Consolidate.
-    message = isolate->message_handler()->queue()->DequeueNoWait();
-    if (message == NULL) {
-      break;
-    }
-    const Instance& msg =
-        Instance::Handle(isolate, DeserializeMessage(isolate, message->data()));
-    priority = message->priority();
-    if (priority == Message::kOOBPriority) {
-      // For now the only OOB messages are Mirrors messages.
-      const Object& result = Object::Handle(
-          isolate,
-          DartLibraryCalls::HandleMirrorsMessage(
-              message->dest_port(), message->reply_port(), msg));
-      delete message;
-      if (result.IsError()) {
-        // TODO(turnidge): Propagating the error is probably wrong here.
-        return Api::NewHandle(isolate, result.raw());
-      }
-      ASSERT(result.IsNull());
-    } else {
-      const Object& result = Object::Handle(
-          isolate,
-          DartLibraryCalls::HandleMessage(
-              message->dest_port(), message->reply_port(), msg));
-      delete message;
-      if (result.IsError()) {
-        return Api::NewHandle(isolate, result.raw());
-      }
-      ASSERT(result.IsNull());
-    }
-  } while (priority >= Message::kOOBPriority);
+  CHECK_ISOLATE(isolate);
+  if (!isolate->message_handler()->HandleNextMessage()) {
+    // TODO(turnidge): Clear sticky error here?
+    return Api::NewHandle(isolate, isolate->object_store()->sticky_error());
+  }
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT bool Dart_HasLivePorts() {
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate);
   return isolate->message_handler()->HasLivePorts();
 }
 
@@ skipping 53 matching lines @@
   if (handler == NULL) {
     OS::PrintErr("%s expects argument 'handler' to be non-null.", CURRENT_FUNC);
     return kIllegalPort;
   }
   // Start the native port without a current isolate.
   IsolateSaver saver(Isolate::Current());
   Isolate::SetCurrent(NULL);
 
   NativeMessageHandler* nmh = new NativeMessageHandler(name, handler);
   Dart_Port port_id = PortMap::CreatePort(nmh);
-  nmh->StartWorker();
+  nmh->Run(Dart::thread_pool(), NULL, NULL);
   return port_id;
 }
 
 
 DART_EXPORT bool Dart_CloseNativePort(Dart_Port native_port_id) {
   // Close the native port without a current isolate.
   IsolateSaver saver(Isolate::Current());
   Isolate::SetCurrent(NULL);
 
   // TODO(turnidge): Check that the port is native before trying to close.
@@ skipping 2480 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart