Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: runtime/vm/native_message_handler.h

Issue 9924015: Use the ThreadPool for all isolates and native ports. Previously, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/message_test.cc ('k') | runtime/vm/native_message_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_NATIVE_MESSAGE_HANDLER_H_ 5 #ifndef VM_NATIVE_MESSAGE_HANDLER_H_
6 #define VM_NATIVE_MESSAGE_HANDLER_H_ 6 #define VM_NATIVE_MESSAGE_HANDLER_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "vm/message.h" 9 #include "vm/message_handler.h"
10 10
11 namespace dart { 11 namespace dart {
12 12
13 // A NativeMessageHandler accepts messages and dispatches them to 13 // A NativeMessageHandler accepts messages and dispatches them to
14 // native C handlers. 14 // native C handlers.
15 class NativeMessageHandler : public MessageHandler { 15 class NativeMessageHandler : public MessageHandler {
16 public: 16 public:
17 NativeMessageHandler(const char* name, Dart_NativeMessageHandler func); 17 NativeMessageHandler(const char* name, Dart_NativeMessageHandler func);
18 ~NativeMessageHandler(); 18 ~NativeMessageHandler();
19 19
20 const char* name() const { return name_; } 20 const char* name() const { return name_; }
21 Dart_NativeMessageHandler func() const { return func_; } 21 Dart_NativeMessageHandler func() const { return func_; }
22 22
23 bool HandleMessage(Message* message);
24
23 #if defined(DEBUG) 25 #if defined(DEBUG)
24 // Check that it is safe to access this handler. 26 // Check that it is safe to access this handler.
25 void CheckAccess(); 27 void CheckAccess();
26 #endif 28 #endif
27 29
28 // Delete this handlers when its last live port is closed. 30 // Delete this handlers when its last live port is closed.
29 virtual bool OwnedByPortMap() const { return true; } 31 virtual bool OwnedByPortMap() const { return true; }
30 32
31 // Start a worker thread which will service messages for this handler.
32 //
33 // TODO(turnidge): Instead of starting a worker for each
34 // NativeMessageHandler, we should instead use a shared thread pool
35 // which services a queue of ready MessageHandlers. If we implement
36 // this correctly, the same pool will work for
37 // IsolateMessageHandlers as well.
38 void StartWorker();
39
40 private: 33 private:
41 char* name_; 34 char* name_;
42 Dart_NativeMessageHandler func_; 35 Dart_NativeMessageHandler func_;
43 }; 36 };
44 37
45 } // namespace dart 38 } // namespace dart
46 39
47 #endif // VM_NATIVE_MESSAGE_HANDLER_H_ 40 #endif // VM_NATIVE_MESSAGE_HANDLER_H_
OLDNEW
« no previous file with comments | « runtime/vm/message_test.cc ('k') | runtime/vm/native_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698