Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 9924006: Un-bork v8.gyp after r11010 (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow
Modified:
8 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Un-bork v8.gyp after r11010 TEST=no more warning "Missing input file tools\gyp\..\..\src\src\list-inl.h" Committed: https://code.google.com/p/v8/source/detail?r=11185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Please take a quick look.
8 years, 8 months ago (2012-03-29 13:59:41 UTC) #1
ulan
lgtm
8 years, 8 months ago (2012-03-29 14:00:43 UTC) #2
Philippe
8 years, 8 months ago (2012-03-29 14:02:24 UTC) #3
On 2012/03/29 14:00:43, ulan wrote:
> lgtm

LGTM. I can't believe that I missed that. Thanks for fixing it!

Powered by Google App Engine
This is Rietveld 408576698