[WebUI] Fix rest of CSS style nits so I can turn on CSS checker.

chrome/browser/resources/test_presubmit.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for Web Development Style Guide checker."""
 
 import os
 import re
 import sys
@@ skipping 170 matching lines @@
     self.fake_file.LocalPath().AndReturn(self.fake_file_name)
     # Actual calls to NewContents() are defined in each test.
     self.mox.StubOutWithMock(self.fake_file, 'NewContents')
 
     self.input_api = self.mox.CreateMockAnything()
     self.input_api.re = re
     self.mox.StubOutWithMock(self.input_api, 'AffectedSourceFiles')
     self.input_api.AffectedFiles(
         include_deletes=False, file_filter=None).AndReturn([self.fake_file])
 
-    # Actual creations of PresubmitError are defined in each test.
+    # Actual creations of PresubmitPromptWarning are defined in each test.
     self.output_api = self.mox.CreateMockAnything()
-    self.mox.StubOutWithMock(self.output_api, 'PresubmitError',
+    self.mox.StubOutWithMock(self.output_api, 'PresubmitPromptWarning',
                              use_mock_anything=True)
 
     author_msg = ('Was the CSS checker useful? '
                   'Send feedback or hate mail to dbeam@chromium.org.')
     self.output_api = self.mox.CreateMockAnything()
     self.mox.StubOutWithMock(self.output_api, 'PresubmitNotifyResult',
                              use_mock_anything=True)
     self.output_api.PresubmitNotifyResult(author_msg).AndReturn(None)
 
   def VerifyContentsProducesOutput(self, contents, output):
     self.fake_file.NewContents().AndReturn(contents.splitlines())
-    self.output_api.PresubmitError(
+    self.output_api.PresubmitPromptWarning(
         self.fake_file_name + ':\n' + output.strip()).AndReturn(None)
     self.mox.ReplayAll()
     css_checker.CSSChecker(self.input_api, self.output_api).RunChecks()
 
   def testCssAlphaWithAtBlock(self):
     self.VerifyContentsProducesOutput("""
 <include src="../shared/css/cr/ui/overlay.css">
 <include src="chrome://resources/totally-cool.css" />
 
 /* A hopefully safely ignored comment and @media statement. /**/
@@ skipping 82 matching lines @@
     .ClassName,
     .class_name {""")
 
   def testCssCloseBraceOnNewLine(self):
     self.VerifyContentsProducesOutput("""
 @media { /* TODO(dbeam) Fix this case. */
   .rule {
     display: block;
   }}
 
+@-webkit-keyframe blah {
+  100% { height: -500px 0; }
+}
+
 #rule {
   rule: value; }""", """
 - Always put a rule closing brace (}) on a new line.
     rule: value; }""")
 
   def testCssColonsHaveSpaceAfter(self):
     self.VerifyContentsProducesOutput("""
 div:not(.class):not([attr=5]), /* We should not catch this. */
 div:not(.class):not([attr]) /* Nor this. */ {
   background: -webkit-linear-gradient(left, red,
@@ skipping 21 matching lines @@
 
   def testCssHexCouldBeShorter(self):
     self.VerifyContentsProducesOutput("""
 #abc,
 #abc-,
 #abc-ghij,
 #abcdef-,
 #abcdef-ghij,
 #aaaaaa,
 #bbaacc {
+  background-color: #336699; /* Ignore short hex rule if not gray. */
   color: #999999;
   color: #666;
 }""", """
 - Use abbreviated hex (#rgb) when in form #rrggbb.
-    color: #999999; (replace with #999)""")
+    color: #999999; (replace with #999)
+
+- Use rgb() over #hex when not a shade of gray (like #333).
+    background-color: #336699; (replace with rgb(51, 102, 153))""")
 
   def testCssUseMillisecondsForSmallTimes(self):
     self.VerifyContentsProducesOutput("""
 .transition-0s /* This is gross but may happen. */ {
   transform: one 0.2s;
   transform: two .1s;
   transform: tree 1s;
   transform: four 300ms;
 }""", """
 - Use milliseconds for time measurements under 1 second.
@@ skipping 13 matching lines @@
 - One rule per line (what not to do: color: red; margin: 0;).
     rule: value; rule: value;""")
 
   def testCssOneSelectorPerLine(self):
     self.VerifyContentsProducesOutput("""
 a,
 div,a,
 div,/* Hello! */ span,
 #id.class([dir=rtl):not(.class):any(a, b, d) {
   rule: value;
+}
+
+a,
+div,a {
+  some-other: rule here;
 }""", """
 - One selector per line (what not to do: a, b {}).
     div,a,
-    div, span,""")
-
+    div, span,
+    div,a {""")
 
   def testCssRgbIfNotGray(self):
     self.VerifyContentsProducesOutput("""
 #abc,
 #aaa,
 #aabbcc {
   background: -webkit-linear-gradient(left, from(#abc), to(#def));
   color: #bad;
   color: #bada55;
 }""", """
@@ skipping 46 matching lines @@
     background-position-x: 0em;
     background-position-y: 0ex;
     border-width: 0em;
     border-width: 0mm;
     height: 0cm;
     width: 0in;
 """)
 
 if __name__ == '__main__':
   unittest.main()