[WebUI] Fix rest of CSS style nits so I can turn on CSS checker.

[WebUI] Fix rest of CSS style nits so I can turn on CSS checker.

NOTE: This CL does not convert gray #hex colors to rgb() as this is optional.

BUG=120369
TEST=Nothing breaks, chrome/browser/resources/PRESUBMIT.py is happy.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130317

[Dan Beam, 2012-03-31 07:11:12]

maruel: *.py
nduca: chrome/browser/resources/gpu_internals/*,
chrome/browser/resources/tracing/*
dpapad: chrome/browser/resources/print_preview/*
atwilson: chrome/browser/resources/sync_internals/*
yoshiki: chrome/browser/resources/task_manager/*
estade: everything else

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/bookmark_manager/css/bmm.css (left):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/bookmark_manager/css/bmm.css:136: -webkit-padding-end:
7px;
both of these were overridden, http://jsfiddle.net/B2qeM/1/show/

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/combobutton.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/file_manager/css/combobutton.css:84: margin-left: -2px;
I don't think this works in RTL, but I didn't change the order...

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/file_manager.css (left):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/file_manager/css/file_manager.css:1174:
webkit-transition: opacity 1000ms linear;
I assumed this didn't work without leading -

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/tracing/timeline.css (left):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/tracing/timeline.css:14: border: 1px solid #000060
this was a parse error, which would just skip to the next ; and start parsing
again, let me know what you'd like me to do...

[Andrew T Wilson (Slow), 2012-03-31 16:12:08]

LGTM w/one question.

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:127: box-shadow: 0.2em 0.2em
0.5em #888;
I'm not clear on the style guide - why some colors need to be converted to rgb
while others don't. Perhaps simple greyscale is OK to express as #nnn?

[Dan Beam, 2012-03-31 19:40:21]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/sync_setup_overlay.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/sync_setup_overlay.css:127: box-shadow: 0.2em 0.2em
0.5em #888;
On 2012/03/31 16:12:09, Andrew T Wilson wrote:
> I'm not clear on the style guide - why some colors need to be converted to rgb
> while others don't. Perhaps simple greyscale is OK to express as #nnn?

Exactly, gray scale is OK to keep as #hex.

[Marc-Antoine Ruel (Google), 2012-03-31 23:11:17]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:48: return
f.AbsoluteLocalPath().endswith(('.css', '.html', '.js'))
return f.LocalPath().endswith(('.css', '.html', '.js'))

you don't need it to be absolute.

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:60: return is_resource(f) and
f.AbsoluteLocalPath().startswith(dirs)
same

[Dan Beam, 2012-04-01 01:55:44]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:48: return
f.AbsoluteLocalPath().endswith(('.css', '.html', '.js'))
On 2012/03/31 23:11:17, Marc-Antoine Ruel (Google) wrote:
> return f.LocalPath().endswith(('.css', '.html', '.js'))
> 
> you don't need it to be absolute.

OK, will fix when in corp.

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:60: return is_resource(f) and
f.AbsoluteLocalPath().startswith(dirs)
On 2012/03/31 23:11:17, Marc-Antoine Ruel (Google) wrote:
> same

We do need to get this full path to support people that checkout from various
levels of the source tree, IIRC.

[nduca, 2012-04-01 04:45:52]

lgtm and thanks

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/tracing/timeline.css (left):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/tracing/timeline.css:14: border: 1px solid #000060
Might as well enable it. It looks harmless. :)

[Marc-Antoine Ruel (Google), 2012-04-01 12:40:12]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:60: return is_resource(f) and
f.AbsoluteLocalPath().startswith(dirs)
On 2012/04/01 01:55:44, Dan Beam wrote:
> On 2012/03/31 23:11:17, Marc-Antoine Ruel (Google) wrote:
> > same
> 
> We do need to get this full path to support people that checkout from various
> levels of the source tree, IIRC.

Ugh, ok.

lgtm

[Dan Beam, 2012-04-01 23:22:01]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/PRESUBMIT.py:48: return
f.AbsoluteLocalPath().endswith(('.css', '.html', '.js'))
On 2012/03/31 23:11:17, Marc-Antoine Ruel (Google) wrote:
> return f.LocalPath().endswith(('.css', '.html', '.js'))
> 
> you don't need it to be absolute.

Done.

[yoshiki, 2012-04-02 00:58:19]

task_mananger LGTM.

[Dan Beam, 2012-04-02 07:02:07]

+serya for chrome/browser/resources/file_manager/*

[Dan Beam, 2012-04-02 07:02:32]

+serya for realz

[Dan Beam, 2012-04-02 07:32:08]

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
File chrome/browser/resources/tracing/timeline.css (left):

https://chromiumcodereview.appspot.com/9923005/diff/7049/chrome/browser/resou...
chrome/browser/resources/tracing/timeline.css:14: border: 1px solid #000060
On 2012/04/01 04:45:52, nduca wrote:
> Might as well enable it. It looks harmless. :)

Done.

[SeRya, 2012-04-02 09:50:21]

LGTM for for chrome/browser/resources/file_manager/* with nits.

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/audio_player.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/audio_player.css:41: background-color:
rgb(60, 126, 255) !important;
Why do you change format here and keep in other places?

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/file_manager.css:159:
background-image: -webkit-linear-gradient(top, #fff,#f6f6f6);
space after comma

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/file_manager.css:410: margin: 0 15px
15px;
"0 15px 15px 15px;" (one more 15px)?

[Dan Beam, 2012-04-02 16:47:10]

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/audio_player.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/audio_player.css:41: background-color:
rgb(60, 126, 255) !important;
On 2012/04/02 09:50:22, SeRya wrote:
> Why do you change format here and keep in other places?

At the moment the style guide says shades of gray are OK to leave in #hex (see:
atwilson's question earlier in review).
http://www.chromium.org/developers/web-development-style-guide#TOC-Color

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/file_manager.css:159:
background-image: -webkit-linear-gradient(top, #fff,#f6f6f6);
On 2012/04/02 09:50:22, SeRya wrote:
> space after comma

Done.

https://chromiumcodereview.appspot.com/9923005/diff/6100/chrome/browser/resou...
chrome/browser/resources/file_manager/css/file_manager.css:410: margin: 0 15px
15px;
On 2012/04/02 09:50:22, SeRya wrote:
> "0 15px 15px 15px;" (one more 15px)?

I can add a 4th value if you'd like, but 3 values are valid as well and
correspond to:

  margin: <top> <left & right> <bottom>;

[dpapad, 2012-04-02 16:52:55]

print preview LGTM with question (see below).

http://codereview.chromium.org/9923005/diff/10001/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/9923005/diff/10001/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/print_preview.css:345: background: #ccc;
in some places you convert color codes to RGB, and in others you keep it as hex,
what is the deal with that? I know there have been some updates to the style
guide.

[Dan Beam, 2012-04-02 16:58:39]

http://codereview.chromium.org/9923005/diff/10001/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/print_preview.css (right):

http://codereview.chromium.org/9923005/diff/10001/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/print_preview.css:345: background: #ccc;
On 2012/04/02 16:52:55, dpapad wrote:
> in some places you convert color codes to RGB, and in others you keep it as
hex,
> what is the deal with that? I know there have been some updates to the style
> guide.

From the style guide:
http://www.chromium.org/developers/web-development-style-guide#TOC-Color

  Hex is acceptable for shades of grey.

This isn't to say that one *can't* convert all #hex to rgb(), just that it's
currently not required by the style guide so I didn't do it (as it would've made
this CL even bigger).

Anybody that wants to do this to code they own should feel free to update it or
go about trying to amend the style guide.

[Evan Stade, 2012-04-03 01:54:42]

rs lgtm

[Dan Beam, 2012-04-03 02:14:59]

https://chromiumcodereview.appspot.com/9923005/diff/10001/chrome/browser/reso...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/9923005/diff/10001/chrome/browser/reso...
chrome/browser/resources/bookmark_manager/css/bmm.css:23: -webkit-padding-start:
0;
this should be 3px, whoops

[Evan Stade, 2012-04-03 02:23:10]

I take it back. Please separate the files you want me to review into a separate
CL.

[Dan Beam, 2012-04-03 02:38:02]

On 2012/04/03 02:23:10, Evan Stade wrote:
> I take it back. Please separate the files you want me to review into a
separate
> CL.

Done. https://chromiumcodereview.appspot.com/9958101/