Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 9923001: [OTS] Fails to Reject CID Fonts When Top Dict is Ordered Incorrectly (Closed)

Created:
8 years, 9 months ago by bashi
Modified:
8 years, 8 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

[OTS] Fails to Reject CID Fonts When Top Dict is Ordered Incorrectly If an ROS entry appears in the top directory, it should start with the ROS entry. BUG=chromium:117265 TEST=ran test_{un,}malicious_fonts.sh. Checked bad_cid_font.otf which attached at http://crbug.com/117265 was rejected by idempotent.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M src/cff.cc View 8 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bashi
Yusuke-san, could you take a look next week? This isn't urgent.
8 years, 9 months ago (2012-03-29 02:57:24 UTC) #1
Yusuke Sato
On 2012/03/29 02:57:24, bashik wrote: > Yusuke-san, could you take a look next week? This ...
8 years, 8 months ago (2012-04-02 03:10:07 UTC) #2
bashi
8 years, 8 months ago (2012-04-03 08:18:12 UTC) #3
On 2012/04/02 03:10:07, Yusuke Sato wrote:
> On 2012/03/29 02:57:24, bashik wrote:
> > Yusuke-san, could you take a look next week? This isn't urgent.
> 
> lgtm.
> 
> please add the good and bad fonts to your test suite.

Thanks. Added the fonts to my test directory.

Powered by Google App Engine
This is Rietveld 408576698