Intrinsify methods early. Fix some bugs in trinsified code, mark one precision-related bug as SKIP …

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 87 matching lines @@
   const intptr_t kArrayLengthOffset = 1 * kWordSize;
   Label fall_through;
 
   // Compute the size to be allocated, it is based on the array length
   // and it computed as:
   // RoundedAllocationSize((array_length * kwordSize) + sizeof(RawArray)).
   __ movl(EDI, Address(ESP, kArrayLengthOffset));  // Array Length.
   // Assert that length is a Smi.
   __ testl(EDI, Immediate(kSmiTagSize));
   __ j(NOT_ZERO, &fall_through);
+  __ cmpl(EDI, Immediate(0));
+  __ j(LESS, &fall_through, Assembler::kNearJump);
   intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
   __ leal(EDI, Address(EDI, TIMES_2, fixed_size));  // EDI is a Smi.
   ASSERT(kSmiTagShift == 1);
   __ andl(EDI, Immediate(-kObjectAlignment));
 
   Heap* heap = Isolate::Current()->heap();
 
   // EDI: allocation size.
   __ movl(EAX, Address::Absolute(heap->TopAddress()));
   __ leal(EBX, Address(EAX, EDI, TIMES_1, 0));
 
   // Check if the allocation fits into the remaining space.
   // EAX: potential new object start.
   // EBX: potential next object start.
   // EDI: allocation size.
   __ cmpl(EBX, Address::Absolute(heap->EndAddress()));
-  __ j(ABOVE_EQUAL, &fall_through);
+  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
 
   // Successfully allocated the object(s), now update top to point to
   // next object start and initialize the object.
   __ movl(Address::Absolute(heap->TopAddress()), EBX);
   __ addl(EAX, Immediate(kHeapObjectTag));
 
   // Initialize the tags.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   // EDI: allocation size.
   {
     Label size_tag_overflow, done;
     __ cmpl(EDI, Immediate(RawObject::SizeTag::kMaxSizeTag));
     __ j(ABOVE, &size_tag_overflow, Assembler::kNearJump);
     __ shll(EDI, Immediate(RawObject::kSizeTagBit - kObjectAlignmentLog2));
     __ movl(FieldAddress(EAX, Array::tags_offset()), EDI);  // Tags.
-    __ jmp(&done);
+    __ jmp(&done, Assembler::kNearJump);
 
     __ Bind(&size_tag_overflow);
     __ movl(FieldAddress(EAX, Array::tags_offset()), Immediate(0));
     __ Bind(&done);
   }
 
   // Store class value for array.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   __ movl(EDI, FieldAddress(CTX, Context::isolate_offset()));
@@ skipping 328 matching lines @@
   return false;
 }
 
 
 // Simple implementation: for positive dividend values greater than divisor,
 // return dividend.
 static bool Integer_modulo(Assembler* assembler) {
   Label fall_through, return_zero;
   TestBothArgumentsSmis(assembler, &fall_through);
   // EAX: right argument (divisor)
+  // Check if modulo by zero -> exception thrown in main function.
+  __ cmpl(EAX, Immediate(0));
+  __ j(EQUAL, &fall_through,  Assembler::kNearJump);
   __ movl(EBX, Address(ESP, + 2 * kWordSize));  // Left argument (dividend).
   __ cmpl(EBX, Immediate(0));
   __ j(LESS, &fall_through, Assembler::kNearJump);
   __ cmpl(EBX, EAX);
   __ j(EQUAL, &return_zero, Assembler::kNearJump);
   __ j(GREATER, &fall_through, Assembler::kNearJump);
   __ movl(EAX, EBX);  // Return dividend.
   __ ret();
   __ Bind(&return_zero);
   __ xorl(EAX, EAX);  // Return zero.
@@ skipping 228 matching lines @@
 
 static bool Integer_sar(Assembler* assembler) {
   Label fall_through, shift_count_ok;
   TestBothArgumentsSmis(assembler, &fall_through);
   // Can destroy ECX since we are not falling through.
   Immediate count_limit = Immediate(0x1F);
   // Check that the count is not larger than what the hardware can handle.
   // For shifting right a Smi the result is the same for all numbers
   // >= count_limit.
   __ SmiUntag(EAX);
+  // Negative counts throw exception.
+  __ cmpl(EAX, Immediate(0));
+  __ j(LESS, &fall_through, Assembler::kNearJump);
   __ cmpl(EAX, count_limit);
   __ j(LESS_EQUAL, &shift_count_ok, Assembler::kNearJump);
   __ movl(EAX, count_limit);
   __ Bind(&shift_count_ok);
   __ movl(ECX, EAX);  // Shift amount must be in ECX.
   __ movl(EAX, Address(ESP, + 2 * kWordSize));  // Value.
   __ SmiUntag(EAX);  // Value.
   __ sarl(EAX, ECX);
   __ SmiTag(EAX);
   __ ret();
@@ skipping 541 matching lines @@
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32