Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9918017: Don't use the full filename for hash value when sharding tests, this will make the result depend on… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 5979)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -327,6 +327,14 @@
}
}
}
+ int shards = configuration['shards'];
+ if (shards > 1) {
+ int shard = configuration['shard'];
+ if (testName.hashCode() % shards != shard -1) {
+ return;
+ }
+ }
+
Set<String> expectations = testExpectations.expectations(testName);
if (configuration['report']) {
// Tests with multiple VMOptions are counted more than once.
@@ -380,14 +388,6 @@
bool hasFatalTypeErrors = false,
bool hasRuntimeErrors = false,
Set<String> multitestOutcome = null]) {
- int shards = configuration['shards'];
- if (shards > 1) {
- int shard = configuration['shard'];
- if (filename.hashCode() % shards != shard -1) {
- return;
- }
- }
-
// Cache the test information for each test case.
var info = new TestInformation(filename,
optionsFromFile,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698