Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: test/cctest/test-heap-profiler.cc

Issue 9918005: Current schema of calculation max_snapshot_js_object_id is not always correct. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/profile-generator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // 2 //
3 // Tests for heap profiler 3 // Tests for heap profiler
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "cctest.h" 7 #include "cctest.h"
8 #include "heap-profiler.h" 8 #include "heap-profiler.h"
9 #include "snapshot.h" 9 #include "snapshot.h"
10 #include "utils-inl.h" 10 #include "utils-inl.h"
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 v8::Local<v8::String> s1_str = v8_str("s1"); 417 v8::Local<v8::String> s1_str = v8_str("s1");
418 v8::Local<v8::String> s2_str = v8_str("s2"); 418 v8::Local<v8::String> s2_str = v8_str("s2");
419 const v8::HeapSnapshot* snapshot1 = 419 const v8::HeapSnapshot* snapshot1 =
420 v8::HeapProfiler::TakeSnapshot(s1_str); 420 v8::HeapProfiler::TakeSnapshot(s1_str);
421 421
422 HEAP->CollectAllGarbage(i::Heap::kNoGCFlags); 422 HEAP->CollectAllGarbage(i::Heap::kNoGCFlags);
423 423
424 const v8::HeapSnapshot* snapshot2 = 424 const v8::HeapSnapshot* snapshot2 =
425 v8::HeapProfiler::TakeSnapshot(s2_str); 425 v8::HeapProfiler::TakeSnapshot(s2_str);
426 426
427 // Second snapshot has one more string, it is it's name 's2'. 427 CHECK(snapshot1->GetMaxSnapshotJSObjectId() > 7000);
428 CHECK( 428 CHECK(snapshot1->GetMaxSnapshotJSObjectId() <=
429 snapshot1->GetMaxSnapshotJSObjectId() <= 429 snapshot2->GetMaxSnapshotJSObjectId());
430 snapshot2->GetMaxSnapshotJSObjectId() &&
431 snapshot2->GetMaxSnapshotJSObjectId() <=
432 snapshot1->GetMaxSnapshotJSObjectId() + i::HeapObjectsMap::kObjectIdStep);
433 430
434 const v8::HeapGraphNode* global1 = GetGlobalObject(snapshot1); 431 const v8::HeapGraphNode* global1 = GetGlobalObject(snapshot1);
435 const v8::HeapGraphNode* global2 = GetGlobalObject(snapshot2); 432 const v8::HeapGraphNode* global2 = GetGlobalObject(snapshot2);
436 CHECK_NE_SNAPSHOT_OBJECT_ID(0, global1->GetId()); 433 CHECK_NE_SNAPSHOT_OBJECT_ID(0, global1->GetId());
437 CHECK_EQ_SNAPSHOT_OBJECT_ID(global1->GetId(), global2->GetId()); 434 CHECK_EQ_SNAPSHOT_OBJECT_ID(global1->GetId(), global2->GetId());
438 const v8::HeapGraphNode* A1 = 435 const v8::HeapGraphNode* A1 =
439 GetProperty(global1, v8::HeapGraphEdge::kProperty, "A"); 436 GetProperty(global1, v8::HeapGraphEdge::kProperty, "A");
440 CHECK_NE(NULL, A1); 437 CHECK_NE(NULL, A1);
441 const v8::HeapGraphNode* A2 = 438 const v8::HeapGraphNode* A2 =
442 GetProperty(global2, v8::HeapGraphEdge::kProperty, "A"); 439 GetProperty(global2, v8::HeapGraphEdge::kProperty, "A");
(...skipping 925 matching lines...) Expand 10 before | Expand all | Expand 10 after
1368 // Dipose the persistent handles in a different order. 1365 // Dipose the persistent handles in a different order.
1369 p_AAA.Dispose(); 1366 p_AAA.Dispose();
1370 CHECK_EQ(global_handle_count + 2, 1367 CHECK_EQ(global_handle_count + 2,
1371 v8::HeapProfiler::GetPersistentHandleCount()); 1368 v8::HeapProfiler::GetPersistentHandleCount());
1372 p_CCC.Dispose(); 1369 p_CCC.Dispose();
1373 CHECK_EQ(global_handle_count + 1, 1370 CHECK_EQ(global_handle_count + 1,
1374 v8::HeapProfiler::GetPersistentHandleCount()); 1371 v8::HeapProfiler::GetPersistentHandleCount());
1375 p_BBB.Dispose(); 1372 p_BBB.Dispose();
1376 CHECK_EQ(global_handle_count, v8::HeapProfiler::GetPersistentHandleCount()); 1373 CHECK_EQ(global_handle_count, v8::HeapProfiler::GetPersistentHandleCount());
1377 } 1374 }
OLDNEW
« no previous file with comments | « src/profile-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698