Current schema of calculation max_snapshot_js_object_id is not always correct.

Current schema of calculation max_snapshot_js_object_id is not always correct.
As the result the test is flaky.

BUG=v8/2042
TEST=HeapEntryIdsAndGC
R=mnaganov

[mnaganov (inactive), 2012-03-29 12:12:17]

https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.c...
src/profile-generator.cc:1161: void
HeapSnapshot::RememberLastSnapshotJSObjectId() {
I think, the word 'Snapshot' in the method name is superfluous.

https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.c...
src/profile-generator.cc:3169: snapshot_->RememberLastSnapshotJSObjectId();
I would place this call into GenerateSnapshot. Having it here, one needs to look
into GenerateSnapshot in order to understand, at what stage this happens.

https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.h...
src/profile-generator.h:708: SnapshotObjectId max_snapshot_js_object_id() const
{
I think, a name like 'current_id' is more appropriate. Also, what will happen if
no id was generated yet?

[loislo, 2012-03-29 12:24:37]

On 2012/03/29 12:12:17, Mikhail Naganov (Chromium) wrote:
> https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.cc
> File src/profile-generator.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.c...
> src/profile-generator.cc:1161: void
> HeapSnapshot::RememberLastSnapshotJSObjectId() {
> I think, the word 'Snapshot' in the method name is superfluous.

done

> 
>
https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.c...
> src/profile-generator.cc:3169: snapshot_->RememberLastSnapshotJSObjectId();
> I would place this call into GenerateSnapshot. Having it here, one needs to
look
> into GenerateSnapshot in order to understand, at what stage this happens.

done

> 
> https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.h
> File src/profile-generator.h (right):
> 
>
https://chromiumcodereview.appspot.com/9918005/diff/1/src/profile-generator.h...
> src/profile-generator.h:708: SnapshotObjectId max_snapshot_js_object_id()
const
> {
> I think, a name like 'current_id' is more appropriate. Also, what will happen
if
> no id was generated yet?

last_assigned_id?

[mnaganov (inactive), 2012-03-29 12:32:31]

lgtm