Refactored the CloudPolicyProvider so that it becomes initialized once and stays initialized.

chrome/browser/policy/cloud_policy_subsystem_unittest.cc

Index: chrome/browser/policy/cloud_policy_subsystem_unittest.cc
diff --git a/chrome/browser/policy/cloud_policy_subsystem_unittest.cc b/chrome/browser/policy/cloud_policy_subsystem_unittest.cc
index aca96d4b9bb6796049ec46a17536a0393790889f..054a2a055767631bff71f2aa33acedf478e68dac 100644
--- a/chrome/browser/policy/cloud_policy_subsystem_unittest.cc
+++ b/chrome/browser/policy/cloud_policy_subsystem_unittest.cc
@@ -104,11 +104,10 @@ class CloudPolicySubsystemTestBase : public testing::Test {
  public:
   CloudPolicySubsystemTestBase()
       : ui_thread_(BrowserThread::UI, &loop_),
-        io_thread_(BrowserThread::IO, &loop_) {
-  }
+        file_thread_(BrowserThread::FILE, &loop_),

[Mattias Nissler (ping if slow), 2012/03/30 11:46:35]

why?

[Joao da Silva, 2012/03/30 16:36:58]

Because otherwise the UserPolicyCache DCHECKs on Load(), since it can't post to
FILE. That didn't happen before I introduced the DCHECK, but the cache wasn't
loading either.

+        io_thread_(BrowserThread::IO, &loop_) {}
 
-  virtual ~CloudPolicySubsystemTestBase() {
-  }
+  virtual ~CloudPolicySubsystemTestBase() {}
 
  protected:
   void StopMessageLoop() {
@@ -250,6 +249,7 @@ class CloudPolicySubsystemTestBase : public testing::Test {
 
   MessageLoop loop_;
   content::TestBrowserThread ui_thread_;
+  content::TestBrowserThread file_thread_;
   content::TestBrowserThread io_thread_;
 
   scoped_ptr<EventLogger> logger_;