Add schema chrome-extension-resource:// for extension resources

chrome/common/extensions/extension_file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include "base/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 197 matching lines @@
       .AppendASCII("bad_encoding");
 
   std::string error;
   scoped_refptr<Extension> extension(extension_file_util::LoadExtension(
       install_dir, Extension::LOAD, Extension::STRICT_ERROR_CHECKS, &error));
   ASSERT_TRUE(extension == NULL);
   ASSERT_STREQ("Could not load file 'bad_encoding.js' for content script. "
                "It isn't UTF-8 encoded.", error.c_str());
 }
 
+TEST(ExtensionFileUtil, ExtensionURLToRelativeFilePath) {
 #define URL_PREFIX "chrome-extension://extension-id/"
-
-TEST(ExtensionFileUtil, ExtensionURLToRelativeFilePath) {
   struct TestCase {
     const char* url;
     const char* expected_relative_path;
   } test_cases[] = {
     { URL_PREFIX "simple.html",
       "simple.html" },
     { URL_PREFIX "directory/to/file.html",
       "directory/to/file.html" },
     { URL_PREFIX "escape%20spaces.html",
       "escape spaces.html" },
     { URL_PREFIX "%C3%9Cber.html",
       "\xC3\x9C" "ber.html" },
 #if defined(OS_WIN)
     { URL_PREFIX "C%3A/simple.html",
       "" },
 #endif
     { URL_PREFIX "////simple.html",
       "simple.html" },
     { URL_PREFIX "/simple.html",
       "simple.html" },
     { URL_PREFIX "\\simple.html",
       "simple.html" },
     { URL_PREFIX "\\\\foo\\simple.html",
       "foo/simple.html" },
   };
+#undef URL_PREFIX
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     GURL url(test_cases[i].url);
 #if defined(OS_POSIX)
     FilePath expected_path(test_cases[i].expected_relative_path);
 #elif defined(OS_WIN)
     FilePath expected_path(UTF8ToWide(test_cases[i].expected_relative_path));
 #endif
 
     FilePath actual_path =
         extension_file_util::ExtensionURLToRelativeFilePath(url);
     EXPECT_FALSE(actual_path.IsAbsolute()) <<
       " For the path " << actual_path.value();
     EXPECT_EQ(expected_path.value(), actual_path.value()) <<
       " For the path " << url;
   }
 }
 
+TEST(ExtensionFileUtil, ExtensionResourceURLToFilePath) {
+  // Setup filesystem for testing.
+  FilePath root_path;
+  ASSERT_TRUE(file_util::CreateNewTempDirectory(
+        FILE_PATH_LITERAL(""), &root_path));
+  ASSERT_TRUE(file_util::AbsolutePath(&root_path));
+
+  FilePath api_path = root_path.Append(FILE_PATH_LITERAL("apiname"));
+  ASSERT_TRUE(file_util::CreateDirectory(api_path));
+
+  const char data[] = "Test Data";
+  FilePath resource_path = api_path.Append(FILE_PATH_LITERAL("test.js"));
+  ASSERT_TRUE(file_util::WriteFile(resource_path, data, sizeof(data)));
+  resource_path = api_path.Append(FILE_PATH_LITERAL("escape spaces.js"));
+  ASSERT_TRUE(file_util::WriteFile(resource_path, data, sizeof(data)));
+
+#ifdef FILE_PATH_USES_WIN_SEPARATORS
+#define SEP "\\"
+#else
+#define SEP "/"
+#endif
+#define URL_PREFIX "chrome-extension-resource://"
+  struct TestCase {
+    const char* url;
+    const FilePath::CharType* expected_path;
+  } test_cases[] = {
+    { URL_PREFIX "apiname/test.js",
+      FILE_PATH_LITERAL("test.js") },
+    { URL_PREFIX "/apiname/test.js",
+      FILE_PATH_LITERAL("test.js") },
+    // Test % escape
+    { URL_PREFIX "apiname/%74%65st.js",
+      FILE_PATH_LITERAL("test.js") },
+    { URL_PREFIX "apiname/escape%20spaces.js",
+      FILE_PATH_LITERAL("escape spaces.js") },
+    // Test file does not exist.
+    { URL_PREFIX "apiname/directory/to/file.js",
+      NULL },
+    // Test apiname/../../test.js
+    { URL_PREFIX "apiname/../../test.js",
+      FILE_PATH_LITERAL("test.js") },
+    { URL_PREFIX "apiname/..%2F../test.js",
+      NULL },
+    { URL_PREFIX "apiname/f/../../../test.js",
+      FILE_PATH_LITERAL("test.js") },
+    { URL_PREFIX "apiname/f%2F..%2F..%2F../test.js",
+      NULL },
+  };
+#undef SEP
+#undef URL_PREFIX
+
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
+    GURL url(test_cases[i].url);
+    FilePath expected_path;
+    if (test_cases[i].expected_path)
+      expected_path = root_path.Append(FILE_PATH_LITERAL("apiname")).Append(
+          test_cases[i].expected_path);
+    FilePath actual_path =
+        extension_file_util::ExtensionResourceURLToFilePath(url, root_path);
+    EXPECT_EQ(expected_path.value(), actual_path.value()) <<
+      " For the path " << url;
+  }
+  // Remove temp files.
+  ASSERT_TRUE(file_util::Delete(root_path, true));
+}
+
 static scoped_refptr<Extension> LoadExtensionManifest(
     DictionaryValue* manifest,
     const FilePath& manifest_dir,
     Extension::Location location,
     int extra_flags,
     std::string* error) {
   scoped_refptr<Extension> extension = Extension::Create(
       manifest_dir, location, *manifest, extra_flags, error);
   return extension;
 }
@@ skipping 83 matching lines @@
   EXPECT_FALSE(extension_file_util::ValidateExtension(extension, &error));
   EXPECT_EQ(l10n_util::GetStringFUTF8(
       IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED,
       ASCIIToUTF16("http://google.com/foo.js")),
            error);
 }
 
 // TODO(aa): More tests as motivation allows. Maybe steal some from
 // ExtensionService? Many of them could probably be tested here without the
 // MessageLoop shenanigans.