Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 9909004: Fix some grammatical errors in comments in net/ (Closed)

Created:
8 years, 9 months ago by gavinp
Modified:
8 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix some grammatical errors in comments in net/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130359

Patch Set 1 #

Total comments: 1

Patch Set 2 : avoid serial genitives #

Total comments: 1

Patch Set 3 : does this make sense? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M net/base/upload_data.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M net/data/proxy_resolver_perftest/no-ads.pac View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/flip_server/balsa_visitor_interface.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
wdyt?
8 years, 9 months ago (2012-03-28 23:36:16 UTC) #1
mmenke
LGTM. https://chromiumcodereview.appspot.com/9909004/diff/1/net/cookies/cookie_monster.cc File net/cookies/cookie_monster.cc (right): https://chromiumcodereview.appspot.com/9909004/diff/1/net/cookies/cookie_monster.cc#newcode2670 net/cookies/cookie_monster.cc:2670: // The Mozilla code broke it into 3 ...
8 years, 9 months ago (2012-03-28 23:54:37 UTC) #2
gavinp
On 2012/03/28 23:54:37, Matt Menke wrote: > LGTM. > > https://chromiumcodereview.appspot.com/9909004/diff/1/net/cookies/cookie_monster.cc > File net/cookies/cookie_monster.cc (right): ...
8 years, 8 months ago (2012-03-30 01:29:31 UTC) #3
mmenke
Tuesday? Do you think we'll have that one comment making sense that soon? :) http://codereview.chromium.org/9909004/diff/4001/net/cookies/cookie_monster.cc ...
8 years, 8 months ago (2012-03-30 01:39:57 UTC) #4
gavinp
On 2012/03/30 01:39:57, Matt Menke wrote: > Tuesday? Do you think we'll have that one ...
8 years, 8 months ago (2012-03-30 01:53:50 UTC) #5
mmenke
8 years, 8 months ago (2012-03-30 01:56:44 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698