Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 99053002: Make LCodeGen::RegisterDependentCodeForEmbeddedMaps platform independent. (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

Make LCodeGen::RegisterDependentCodeForEmbeddedMaps platform independent. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18231

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -133 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +1 line, -33 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +1 line, -33 lines 0 comments Download
M src/lithium-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +1 line, -33 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look. This removes duplicate platform-specific code.
7 years ago (2013-12-02 13:01:12 UTC) #1
Hannes Payer (out of office)
LGTM
7 years ago (2013-12-02 16:10:53 UTC) #2
ulan
7 years ago (2013-12-03 12:32:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r18231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698