PpapiCommandBufferProxy implements CommandBufferProxy.

gpu/ipc/command_buffer_proxy.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_CLIENT_COMMAND_BUFFER_PROXY_H_

[jam, 2012/03/30 21:45:29]

nit: update header guards

[Fady Samuel, 2012/04/02 01:01:09]

Done.

 #define CONTENT_COMMON_GPU_CLIENT_COMMAND_BUFFER_PROXY_H_
 #pragma once
 
-#if defined(ENABLE_GPU)
-
 #include <string>
 
 #include "base/callback.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/common/gpu/client/gpu_video_decode_accelerator_host.h"

[jam, 2012/03/30 21:45:29]

this is a layering violation, the "gpu" module is below "content" and shouldn't
include it. so you can't commit this as is.

[jam, 2012/03/30 21:46:51]

btw the "checkdeps" failure on the try run is trying o tell you this too :)

[Fady Samuel, 2012/04/02 01:01:09]

Done.

 #include "gpu/command_buffer/common/command_buffer.h"
 #include "gpu/command_buffer/common/command_buffer_shared.h"
 
 struct GpuMemoryAllocationForRenderer;
 
 // Client side proxy that forwards messages synchronously to a
 // CommandBufferStub.
-class CommandBufferProxy : public gpu::CommandBuffer {
+class GPU_EXPORT CommandBufferProxy : public gpu::CommandBuffer {
  public:
   typedef base::Callback<void(
       const std::string& msg, int id)> GpuConsoleMessageCallback;
 
   CommandBufferProxy() { }
 
   virtual ~CommandBufferProxy() { }
 
   virtual int GetRouteID() const = 0;
 
@@ skipping 35 matching lines @@
       media::VideoCodecProfile profile,
       media::VideoDecodeAccelerator::Client* client) = 0;
 
   virtual void SetOnConsoleMessageCallback(
       const GpuConsoleMessageCallback& callback) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CommandBufferProxy);
 };
 
-#endif  // ENABLE_GPU
-
 #endif  // CONTENT_COMMON_GPU_CLIENT_COMMAND_BUFFER_PROXY_H_